Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ISO 639 (639-1, 639-2/T, 639-2/B) codes used to classify languages #84

Closed
ChristopherJHart opened this issue Aug 5, 2023 · 2 comments · Fixed by #141
Assignees
Labels

Comments

@ChristopherJHart
Copy link

ChristopherJHart commented Aug 5, 2023

It could be useful to have ISO 639-based language codes added as types in this project. I wouldn't mind working on a PR to add this in, assuming the team agrees it'd be valuable.

Thank you!

Selected Assignee: @adriangb

@adriangb
Copy link
Member

adriangb commented Aug 8, 2023

That sounds reasonable to me. My only suggestion before you start work is that I'd rather they be Literals and not an enum if it makes sense to do it that way.

@yezz123 yezz123 added Types and removed unconfirmed labels Feb 24, 2024
@yezz123 yezz123 assigned yezz123 and unassigned adriangb Feb 24, 2024
@yezz123
Copy link
Collaborator

yezz123 commented Feb 24, 2024

Hello @adriangb @ChristopherJHart

Already @07pepa opened a PR regarding this and using literal as @adriangb recommends but what I notice is that already we can use pycountry to build this #141 (comment)

@yezz123 yezz123 linked a pull request Feb 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants