Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpga: Add flow and CI for implementation on VCU128 boards #75

Merged
merged 1 commit into from
Jul 9, 2023
Merged

fpga: Add flow and CI for implementation on VCU128 boards #75

merged 1 commit into from
Jul 9, 2023

Conversation

CyrilKoe
Copy link
Contributor

@CyrilKoe CyrilKoe commented Jun 28, 2023 •
edited
Loading

Modifications :

  • hw : Added configuration to disable islands
  • target/xilinx : Added scripts, wrappers, constraints for VCU128 (tested) and ZCU102 (non tested)
  • target/xilinx/overrides : Some files were causing issues on the Vivado flow, I added comments there (not actual patches) in order not to open PRs everywhere. Is this a copyright issue? It can be removed before Carfield is open sourced.

Tests:

  • Host : Bitstream compiles, JTAG works
  • Host + Safety : Bitstream compiles, JTAG fails on the safety
  • Host + Safety + Pulp : Bitstream compiles
  • Host + Spatz : Bitstream compiles

Todo:

  • Add Yann's error slaves when disabling an island
  • Tests
  • Add support for VCU128'flash with opentitan's SPI driver and connection to external DDR4 (removed atm for simplicity of diffs).

This PR goes with the following MR
https://iis-git.ee.ethz.ch/carfield/carfield-nonfree/-/merge_requests/14

@CyrilKoe CyrilKoe requested a review from luca-valente as a code owner June 28, 2023 10:07
luca-valente
luca-valente reviewed Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@luca-valente luca-valente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very very nice, left some comments to define the best way to proceed 😄

target/xilinx/Makefile Outdated Show resolved Hide resolved
target/xilinx/constraints/vcu128.xdc Show resolved Hide resolved
Bender.yml Outdated Show resolved Hide resolved
target/xilinx/Makefile Outdated Show resolved Hide resolved
target/xilinx/constraints/vcu128.xdc Show resolved Hide resolved
@CyrilKoe CyrilKoe marked this pull request as draft June 30, 2023 13:15
@CyrilKoe CyrilKoe changed the title fpga: Added flow and CI for implementation on VCU128 boards (draft) fpga: Added flow and CI for implementation on VCU128 boards Jun 30, 2023
@CyrilKoe CyrilKoe force-pushed the fpga/pr1 branch 2 times, most recently from 2af6cd2 to 75819d8 Compare June 30, 2023 13:32
@alex96295 alex96295 changed the title (draft) fpga: Added flow and CI for implementation on VCU128 boards Draft: fpga: Added flow and CI for implementation on VCU128 boards Jul 2, 2023
@CyrilKoe CyrilKoe force-pushed the fpga/pr1 branch 3 times, most recently from 3398761 to ed32baa Compare July 4, 2023 11:39
@CyrilKoe CyrilKoe marked this pull request as ready for review July 4, 2023 15:57
@CyrilKoe
Copy link
Contributor Author

CyrilKoe commented Jul 4, 2023 •
edited
Loading

Ready to be reviewed @luca-valente @alex96295 @anga93 :)

@CyrilKoe
Copy link
Contributor Author

CyrilKoe commented Jul 4, 2023

Note the xdc split will be addressed in a next PR

@CyrilKoe CyrilKoe changed the title Draft: fpga: Added flow and CI for implementation on VCU128 boards fpga: Added flow and CI for implementation on VCU128 boards Jul 4, 2023
luca-valente
luca-valente reviewed Jul 5, 2023
View reviewed changes
Copy link
Collaborator

@luca-valente luca-valente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, left only a minor comment

target/xilinx/scripts/overrides.sh Show resolved Hide resolved
alex96295
alex96295 reviewed Jul 5, 2023
View reviewed changes
Bender.yml Outdated Show resolved Hide resolved
alex96295
alex96295 reviewed Jul 5, 2023
View reviewed changes
carfield.mk Outdated Show resolved Hide resolved
@alex96295 alex96295 changed the title fpga: Added flow and CI for implementation on VCU128 boards fpga: Add flow and CI for implementation on VCU128 boards Jul 5, 2023
@alex96295
Copy link
Collaborator

I left few minor comments, great work!

I will merge in the next few days after you address what is left :)

@CyrilKoe CyrilKoe force-pushed the fpga/pr1 branch 2 times, most recently from d72d32c to 13cca0c Compare July 6, 2023 15:03
@CyrilKoe
fpga: Added flow and CI for implementation on VCU128 boards, added ov…
cfa86f2 
…erride files for Vivado compilation only

fpga: switched to xilinx.mk and removed non essential overrides

fpga: switched safety island bootmode and removed last override
@CyrilKoe
Copy link
Contributor Author

CyrilKoe commented Jul 6, 2023

Back to overriding tc_clk_xilinx until we discuss the tech_cells_generic case

alex96295
alex96295 approved these changes Jul 9, 2023
View reviewed changes
Copy link
Collaborator

@alex96295 alex96295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@alex96295 alex96295 merged commit ba76551 into main Jul 9, 2023
@micprog micprog deleted the fpga/pr1 branch July 21, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-valente luca-valente luca-valente left review comments

@alex96295 alex96295 alex96295 approved these changes

Assignees

@anga93 anga93

@alex96295 alex96295

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CyrilKoe @alex96295 @luca-valente @anga93