Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add and implement PullRequest.reopen() #714

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpopelka
Copy link
Member

I'd like to use this functionality in hardly.

http POST https://pagure.io/api/0/ogr-tests/pull-request/16/close 'Authorization:token my-token' still returns "Invalid or expired token..." even I just generated it with all ACLs.
In case it works for you, please uncomment the test_pr_close_reopen() for pagure and generate the response files. Thanks!!

RELEASE NOTES BEGIN
PullRequest now contains reopen() method implemented by its subclasses.
RELEASE NOTES END

@softwarefactory-project-zuul

This comment was marked as outdated.

@jpopelka
Copy link
Member Author

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@jpopelka jpopelka changed the title Add and implement PullRequest.reopen() WIP: Add and implement PullRequest.reopen() Apr 29, 2022
@jpopelka
Copy link
Member Author

I need to look at the Pagure again since the /reopen endpoint doesn't seem to exist in pagure.io or src.fedoraproject.org even it should have been implemented since https://pagure.io/pagure/pull-request/3349

@mfocko
Copy link
Member

mfocko commented May 1, 2022

Pagure API support here: https://pagure.io/pagure/pull-request/5291

@jpopelka
Copy link
Member Author

jpopelka commented May 2, 2022

You're my personal hero, Maťo!

softwarefactory-project-zuul bot added a commit to packit/hardly that referenced this pull request May 10, 2022
Sync to dist-git MR when source-git MR has been closed or reopened

Test on staging - seems to work OK



Fixes

#35
#47

Merge after

packit/packit-service#1492
packit/ogr#714 (probably won't wait for it since it's blocked on Pagure)

Reviewed-by: Tomas Tomecek <[email protected]>
Reviewed-by: Jiri Popelka <None>
@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jul 10, 2022
@mfocko
Copy link
Member

mfocko commented Jul 11, 2022

pinged Pagure side... once again...

@stale stale bot removed the stale Is the issue still valid? label Jul 11, 2022
@mfocko
Copy link
Member

mfocko commented Aug 19, 2022

Unblocked, not yet deployed

@stale
Copy link

stale bot commented Oct 30, 2022

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@mfocko
Copy link
Member

mfocko commented Oct 30, 2022

Merged on Pagure' side, not yet released neither deployed…

@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been marked as stale because it hasn't seen any
activity for the last 60 days.

Stale issues are closed after 14 days, unless the label is removed
by a maintainer or someone comments on it.

This is done in order to ensure that open issues are still relevant.

Thank you for your contribution! 🦄 🚀 🤖

(Note: issues labeled with pinned or EPIC are
never marked as stale.)

@stale stale bot added the stale Is the issue still valid? label Jan 7, 2023
@jpopelka
Copy link
Member Author

jpopelka commented Jan 9, 2023

Still waiting for >5.13.3 release

@stale stale bot removed the stale Is the issue still valid? label Jan 9, 2023
@mfocko
Copy link
Member

mfocko commented Jan 13, 2023

I'm considering finishing this with a local deployment, cause I have a feeling this PR will live longer than all of us…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants