This repository has been archived by the owner on Sep 25, 2024. It is now read-only.
Sync to dist-git MR when source-git MR has been closed or reopened #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 6, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
1 task
jpopelka
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 9, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 9, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 9, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
This comment was marked as outdated.
This comment was marked as outdated.
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 9, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
We don't need the dist_git_branch variable because if the downstream branch doesn't exist none of the followup code is executed.
TomasTomecek
reviewed
May 9, 2022
hardly/handlers/distgit.py
Outdated
Comment on lines
127
to
138
| if ( | ||
| self.target_repo_branch | ||
| not in self.packit.dg.local_project.git_project.get_branches() | ||
| ): | ||
| msg = f"Downstream {self.target_repo}:{self.target_repo_branch} branch does not exist." | ||
| self.project.get_pr(int(self.mr_identifier)).comment(msg) | ||
| logger.info(msg) | ||
| return TaskResults(success=True) |
There was a problem hiding this comment.
We should probably put more text in the comment to guide contributors/maintainers.
There was a problem hiding this comment.
This was added in #56 and I don't think it'll happen too often because the source-git branches should in general match dist-git branches. But I tried to add more context to the message. Check the latest commit.
| logger.error(f"Unknown action {self.action}") | ||
| return TaskResults(success=False) | ||
| logger.info(msg) | ||
| self.dist_git_pr.comment(msg) |
There was a problem hiding this comment.
I hope folks won't find this as spamming but it's totally significant to inform about such an action in the downstream PR.
There was a problem hiding this comment.
Yes, and in most cases, you close the source-git MR only once, so it's just one comment.
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 9, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 40s |
TomasTomecek
approved these changes
May 9, 2022
Comment on lines
+132
to
+134
| "Can't create a dist-git pull/merge request out of this contribution " | ||
| f"because matching {self.target_repo_branch} branch does not exist " | ||
| f"in dist-git {self.target_repo} repo." |
jpopelka
added a commit
to jpopelka/packit-service
that referenced
this pull request
May 10, 2022
I need this for hardly, where we want to react when a source-git MR gets closed. packit/hardly#62
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 39s |
softwarefactory-project-zuul bot
added a commit
that referenced
this pull request
May 18, 2022
Improve code added in #62 I initially wanted to attach these refactoring commits to some other PR, but I think they'll be better on their own. Reviewed-by: None <None> Reviewed-by: Jiri Popelka <None>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Merge after