WIP: Add and implement PullRequest.reopen()

Makefile

@@ -12,7 +12,8 @@ check:
 	PYTHONPATH=$(CURDIR) PYTHONDONTWRITEBYTECODE=1 pytest --verbose --showlocals $(TEST_TARGET)
 
 check-in-container:
-	podman run --rm -it -v $(CURDIR):/src:Z -w /src --env TEST_TARGET $(OGR_IMAGE) make -e GITHUB_TOKEN=$(GITHUB_TOKEN) GITLAB_TOKEN=$(GITLAB_TOKEN) check
+	podman run --rm -it -v $(CURDIR):/src:Z -w /src --env TEST_TARGET $(OGR_IMAGE) \
+		make -e GITHUB_TOKEN=$(GITHUB_TOKEN) GITLAB_TOKEN=$(GITLAB_TOKEN) PAGURE_TOKEN=$(PAGURE_TOKEN) check
 
 shell:
 	podman run --rm -ti -v $(CURDIR):/src:Z -w /src $(OGR_IMAGE) bash

files/tasks/build-rpm-deps.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Install RPM build dependencies
-  command: dnf -y builddep fedora/python-ogr.spec
+  ansible.builtin.command: dnf -y builddep fedora/python-ogr.spec
   args:
     chdir: "{{ project_dir }}"
   become: true

files/tasks/configure-git.yaml

@@ -1,5 +1,5 @@
 ---
 - name: "set up git: email"
-  command: git config --global user.email [email protected]
+  ansible.builtin.command: git config --global user.email [email protected]
 - name: "set up git: name"
-  command: git config --global user.name "OGR Test Suite"
+  ansible.builtin.command: git config --global user.name "OGR Test Suite"

files/tasks/generic-dnf-requirements.yaml

@@ -1,14 +1,14 @@
 ---
 - name: Install generic RPM packages
-  dnf:
+  ansible.builtin.dnf:
     name:
       - make
       - git
       - dnf-utils
       - python3-pip
   become: true
 - name: Install rpmautospec-rpm-macros
-  dnf:
+  ansible.builtin.dnf:
     name:
       - rpmautospec-rpm-macros
   # rpmautospec-rpm-macros is not in epel

files/tasks/install-ogr.yaml

@@ -1,7 +1,7 @@
 ---
 - name: Print the current working directory
-  command: pwd
+  ansible.builtin.command: pwd
 - name: Install ogr from {{ project_dir }}
-  pip:
+  ansible.builtin.pip:
     name: "{{ project_dir }}"
   become: true

files/tasks/packit-requirements.yaml

@@ -1,12 +1,12 @@
 ---
 - name: Install ansible
-  dnf:
+  ansible.builtin.dnf:
     name:
       - ansible
     state: present
   become: true
 
 - name: Install packit dependencies via ansible playbooks
-  command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/install-requirements-pip.yaml
+  ansible.builtin.command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/install-requirements-pip.yaml
   args:
     chdir: "{{ reverse_dir }}"

files/tasks/packit-tests.yaml

@@ -1,9 +1,9 @@
 ---
 - name: install and run basic packit tests via ansible playbooks
-  command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/zuul-tests.yaml
+  ansible.builtin.command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/zuul-tests.yaml
   args:
     chdir: "{{ reverse_dir }}"
 - name: install and run packit tests with session recording via ansible playbooks
-  command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/zuul-tests-session-recording.yaml
+  ansible.builtin.command: ansible-playbook -e "ansible_python_interpreter=/usr/bin/python3" -v -c local -i localhost, files/zuul-tests-session-recording.yaml
   args:
     chdir: "{{ reverse_dir }}"

files/tasks/project-dir.yaml

@@ -1,17 +1,17 @@
 ---
-- set_fact:
+- ansible.builtin.set_fact:
     project_dir: "{{ playbook_dir }}/.."
   when: zuul is not defined
-- set_fact:
+- ansible.builtin.set_fact:
     project_dir: "{{ ansible_user_dir }}/{{ zuul.project.src_dir }}"
   when: zuul is defined
 - name: stat {{ project_dir }}
-  stat:
+  ansible.builtin.stat:
     path: "{{ project_dir }}"
   tags:
     - no-cache
   register: src_path
 - name: Make sure {{ project_dir }} is present
-  assert:
+  ansible.builtin.assert:
     that:
       - src_path.stat.isdir

files/tasks/python-compile-deps.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Install specific RPMs to be able to use PIP installation
-  dnf:
+  ansible.builtin.dnf:
     name:
       - krb5-devel
       - gcc

files/tasks/rpm-test-deps.yaml

@@ -1,6 +1,6 @@
 ---
 - name: Install test rpm dependencies
-  dnf:
+  ansible.builtin.dnf:
     name:
       - python3-pip
       - python3-setuptools
@@ -14,7 +14,7 @@
     state: present
   become: true
 - name: Install requre from git
-  pip:
+  ansible.builtin.pip:
     name:
       - git+https://github.com/packit/requre.git
     state: latest

files/zuul-install-requirements-pip.yaml

@@ -5,7 +5,7 @@
     - include_tasks: tasks/generic-dnf-requirements.yaml
     - include_tasks: tasks/python-compile-deps.yaml
     - name: Install deps from PyPI
-      pip:
+      ansible.builtin.pip:
         name: "{{ item }}"
       with_items:
         - PyGithub

files/zuul-install-requirements-rpms.yaml

@@ -6,7 +6,7 @@
     - include_tasks: tasks/generic-dnf-requirements.yaml
     - include_tasks: tasks/build-rpm-deps.yaml
     - name: Install deps as RPMs
-      dnf:
+      ansible.builtin.dnf:
         name:
           - python3-pygithub
           - python3-gitlab

files/zuul-reverse-dep-packit.yaml

@@ -2,7 +2,7 @@
 - name: Check if we are not breaking packit
   hosts: all
   tasks:
-    - set_fact:
+    - ansible.builtin.set_fact:
         reverse_dir: "{{ ansible_user_dir }}/{{ zuul.projects['github.com/packit/packit'].src_dir }}"
     - include_tasks: tasks/project-dir.yaml
     - include_tasks: tasks/generic-dnf-requirements.yaml

files/zuul-tests.yaml

@@ -7,6 +7,6 @@
     - include_tasks: tasks/install-ogr.yaml
     - include_tasks: tasks/configure-git.yaml
     - name: Run tests
-      command: make check
+      ansible.builtin.command: make check
       args:
         chdir: "{{ project_dir }}"

ogr/abstract.py

@@ -866,6 +866,15 @@ def close(self) -> "PullRequest":
         """
         raise NotImplementedError()
 
+    def reopen(self) -> "PullRequest":
+        """
+        Reopen closed pull request.
+
+        Returns:
+            Pull request itself.
+        """
+        raise NotImplementedError()
+
     def merge(self) -> "PullRequest":
         """
         Merge the pull request.

ogr/services/github/pull_request.py

@@ -240,6 +240,10 @@ def close(self) -> "PullRequest":
         self._raw_pr.edit(state=PRStatus.closed.name)
         return self
 
+    def reopen(self) -> "PullRequest":
+        self._raw_pr.edit(state=PRStatus.open.name)
+        return self
+
     def merge(self) -> "PullRequest":
         self._raw_pr.merge()
         return self

ogr/services/gitlab/pull_request.py

@@ -279,6 +279,11 @@ def close(self) -> "PullRequest":
         self._raw_pr.save()
         return self
 
+    def reopen(self) -> "PullRequest":
+        self._raw_pr.state_event = "reopen"
+        self._raw_pr.save()
+        return self
+
     def merge(self) -> "PullRequest":
         self._raw_pr.merge()
         return self

ogr/services/pagure/pull_request.py

@@ -251,6 +251,15 @@ def close(self) -> "PullRequest":
         self.__dirty = True
         return self
 
+    def reopen(self) -> "PullRequest":
+        return_value = self.__call_api("close", method="POST")
+
+        if return_value["message"] != "Pull request reopened!":
+            raise PagureAPIException(return_value["message"])
+
+        self.__dirty = True
+        return self
+
     def merge(self) -> "PullRequest":
         return_value = self.__call_api("merge", method="POST")