Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed logic for credential proof headers #1357

Merged

Conversation

al-rosenthal
Copy link
Contributor

@al-rosenthal al-rosenthal commented Dec 11, 2024

Summary of Changes

  • Updated header logic on proof request lists to display properly
  • Updated test snapshot

Screenshots, videos, or gifs

Proof request screen breaks down into 2 section:

  • "Missing Credentials"
  • "From your wallet"

Missing credentials do not exist in the users wallet, we only want the headers to appear when there are credentials in the proof that appear in both sections

Credentials in both sections:
dummy

No section headers required when credentials are in one of these sections:
dummy

Breaking change guide

n/a

Related Issues

BC-Wallet: 2303

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this)
  • If applicable, screenshots, gifs, or video are included for UI changes
  • If applicable, breaking changes are described above along with how to address them
  • Updated documentation as needed for changed code and new or modified features
  • Added sufficient tests so that overall code coverage is not reduced

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated checks have passed

Copy link

sonarcloud bot commented Dec 11, 2024

@bryce-mcmath bryce-mcmath merged commit 6f8357a into openwallet-foundation:main Dec 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants