fix: fixed logic for credential proof headers (#1357)

Signed-off-by: al-rosenthal <[email protected]>
openwallet-foundation · Dec 11, 2024 · 6f8357a · 6f8357a
1 parent e4bb384
commit 6f8357a
Show file tree

Hide file tree

Showing 2 changed files with 100 additions and 2 deletions.
diff --git a/packages/legacy/core/App/screens/ProofRequest.tsx b/packages/legacy/core/App/screens/ProofRequest.tsx
@@ -834,7 +834,7 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => {
           {!hasAvailableCredentials && (
             <CredentialList
               header={
-                missingCredentials.length > 1 && userCredentials.length > 1
+                missingCredentials.length > 0 && userCredentials.length > 0
                   ? credentialListHeader(t('ProofRequest.MissingCredentials'))
                   : undefined
               }
@@ -856,7 +856,7 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => {
           )}
           <CredentialList
             header={
-              missingCredentials.length > 1 && userCredentials.length > 1
+              missingCredentials.length > 0 && userCredentials.length > 0
                 ? credentialListHeader(t('ProofRequest.FromYourWallet'))
                 : undefined
             }

diff --git a/packages/legacy/core/__tests__/screens/__snapshots__/W3cProofRequest.test.tsx.snap b/packages/legacy/core/__tests__/screens/__snapshots__/W3cProofRequest.test.tsx.snap
@@ -163,6 +163,29 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
               }
             />
           }
+          ListHeaderComponent={
+            <View
+              style={
+                Object {
+                  "marginHorizontal": 20,
+                }
+              }
+            >
+              <Text
+                style={
+                  Object {
+                    "color": "#FFFFFF",
+                    "fontSize": 20,
+                    "fontWeight": "bold",
+                    "marginTop": 10,
+                  }
+                }
+                testID="com.ariesbifold:id/ProofRequestHeaderText"
+              >
+                ProofRequest.MissingCredentials
+              </Text>
+            </View>
+          }
           data={
             Array [
               Object {
@@ -213,6 +236,32 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
           viewabilityConfigCallbackPairs={Array []}
         >
           <View>
+            <View
+              collapsable={false}
+              onLayout={[Function]}
+            >
+              <View
+                style={
+                  Object {
+                    "marginHorizontal": 20,
+                  }
+                }
+              >
+                <Text
+                  style={
+                    Object {
+                      "color": "#FFFFFF",
+                      "fontSize": 20,
+                      "fontWeight": "bold",
+                      "marginTop": 10,
+                    }
+                  }
+                  testID="com.ariesbifold:id/ProofRequestHeaderText"
+                >
+                  ProofRequest.MissingCredentials
+                </Text>
+              </View>
+            </View>
             <View
               onFocusCapture={[Function]}
               onLayout={[Function]}
@@ -604,6 +653,29 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
           </View>
         </RCTScrollView>
         <RCTScrollView
+          ListHeaderComponent={
+            <View
+              style={
+                Object {
+                  "marginHorizontal": 20,
+                }
+              }
+            >
+              <Text
+                style={
+                  Object {
+                    "color": "#FFFFFF",
+                    "fontSize": 20,
+                    "fontWeight": "bold",
+                    "marginTop": 10,
+                  }
+                }
+                testID="com.ariesbifold:id/ProofRequestHeaderText"
+              >
+                ProofRequest.FromYourWallet
+              </Text>
+            </View>
+          }
           data={
             Array [
               Object {
@@ -699,6 +771,32 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
           viewabilityConfigCallbackPairs={Array []}
         >
           <View>
+            <View
+              collapsable={false}
+              onLayout={[Function]}
+            >
+              <View
+                style={
+                  Object {
+                    "marginHorizontal": 20,
+                  }
+                }
+              >
+                <Text
+                  style={
+                    Object {
+                      "color": "#FFFFFF",
+                      "fontSize": 20,
+                      "fontWeight": "bold",
+                      "marginTop": 10,
+                    }
+                  }
+                  testID="com.ariesbifold:id/ProofRequestHeaderText"
+                >
+                  ProofRequest.FromYourWallet
+                </Text>
+              </View>
+            </View>
             <View
               onFocusCapture={[Function]}
               onLayout={[Function]}