Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed logic for credential proof headers #1357

Merged
merged 2 commits into from
Dec 11, 2024
Merged

fix: fixed logic for credential proof headers #1357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
272e1f7
fix: fixed logic for credential proof headers
al-rosenthal Dec 11, 2024
b4d3262
test: updated test template
al-rosenthal Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/legacy/core/App/screens/ProofRequest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => {
{!hasAvailableCredentials && (
<CredentialList
header={
missingCredentials.length > 1 && userCredentials.length > 1
missingCredentials.length > 0 && userCredentials.length > 0
? credentialListHeader(t('ProofRequest.MissingCredentials'))
: undefined
}
Expand All @@ -856,7 +856,7 @@ const ProofRequest: React.FC<ProofRequestProps> = ({ navigation, proofId }) => {
)}
<CredentialList
header={
missingCredentials.length > 1 && userCredentials.length > 1
missingCredentials.length > 0 && userCredentials.length > 0
? credentialListHeader(t('ProofRequest.FromYourWallet'))
: undefined
}
Expand Down
98 changes: 98 additions & 0 deletions packages/legacy/core/__tests__/screens/__snapshots__/W3cProofRequest.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,29 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
}
/>
}
ListHeaderComponent={
<View
style={
Object {
"marginHorizontal": 20,
}
}
>
<Text
style={
Object {
"color": "#FFFFFF",
"fontSize": 20,
"fontWeight": "bold",
"marginTop": 10,
}
}
testID="com.ariesbifold:id/ProofRequestHeaderText"
>
ProofRequest.MissingCredentials
</Text>
</View>
}
data={
Array [
Object {
Expand Down Expand Up @@ -213,6 +236,32 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
viewabilityConfigCallbackPairs={Array []}
>
<View>
<View
collapsable={false}
onLayout={[Function]}
>
<View
style={
Object {
"marginHorizontal": 20,
}
}
>
<Text
style={
Object {
"color": "#FFFFFF",
"fontSize": 20,
"fontWeight": "bold",
"marginTop": 10,
}
}
testID="com.ariesbifold:id/ProofRequestHeaderText"
>
ProofRequest.MissingCredentials
</Text>
</View>
</View>
<View
onFocusCapture={[Function]}
onLayout={[Function]}
Expand Down Expand Up @@ -604,6 +653,29 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
</View>
</RCTScrollView>
<RCTScrollView
ListHeaderComponent={
<View
style={
Object {
"marginHorizontal": 20,
}
}
>
<Text
style={
Object {
"color": "#FFFFFF",
"fontSize": 20,
"fontWeight": "bold",
"marginTop": 10,
}
}
testID="com.ariesbifold:id/ProofRequestHeaderText"
>
ProofRequest.FromYourWallet
</Text>
</View>
}
data={
Array [
Object {
Expand Down Expand Up @@ -699,6 +771,32 @@ exports[`displays a proof request screen ProofRequest Screen, W3C displays a pro
viewabilityConfigCallbackPairs={Array []}
>
<View>
<View
collapsable={false}
onLayout={[Function]}
>
<View
style={
Object {
"marginHorizontal": 20,
}
}
>
<Text
style={
Object {
"color": "#FFFFFF",
"fontSize": 20,
"fontWeight": "bold",
"marginTop": 10,
}
}
testID="com.ariesbifold:id/ProofRequestHeaderText"
>
ProofRequest.FromYourWallet
</Text>
</View>
</View>
<View
onFocusCapture={[Function]}
onLayout={[Function]}
Expand Down