Add tempest/tempestconf options #10
Conversation
|
Related patch for tcib: openstack-k8s-operators/tcib#95 |
lpiwowar
had a problem deploying
to
github-pages
GitHub Actions
Failure
lpiwowar
changed the title
lpiwowar
force-pushed
the
lpiwowar/feature/python-tempestconf-params
branch
from
9af2a25 to
5cd8350
Compare
|
@arxcruz here is the related PR for tcib => openstack-k8s-operators/tcib#95 |
lpiwowar
force-pushed
the
lpiwowar/feature/python-tempestconf-params
branch
8 times, most recently
from
4d56182 to
f6e4b44
Compare
| type: boolean | ||
| deployerInput: | ||
| default: "" | ||
| description: Path to deployer file |
There was a problem hiding this comment.
How you are going to map the deployer input into the container ?
Should we have predefined location and in case it present use it ?
There was a problem hiding this comment.
I think we've already discussed this. I'm adding it here for reference. The deployerInput is mapped into the tempest pod as a file using ConfigMap - here. The location of the file is set by the test-operator as well one line below.
| // +kubebuilder:validation:Optional | ||
| // +kubebuilder:default:=false | ||
| // Serial run | ||
| Serial bool `json:"serial,omitempty"` |
There was a problem hiding this comment.
aren't serial and Parallel mutually exclusive? Can it be that both will be set to "True" for example?
There was a problem hiding this comment.
It is a good point. I was thinking about the same. But I'm not sure how much should the test-operator contain the logic of using the parameters. For me it is fine that the pod fails when the user decides to use the parameters incorrectly. But I guess it is up for a discussion (@kopecmartin, @afazekas) (?)
There was a problem hiding this comment.
if a user passes both, --serial and --parallel, arguments, tempest will throw an error:
tempest run: error: argument --parallel: not allowed with argument --serial/-t
The way I see it, we don't need to check any argument compatibility on the operator/tempest image side - that's done by tempest itself. The operator together with the image definitions are responsible for getting the arguments from user to tempest - they are just a messenger.
There was a problem hiding this comment.
is there any specific reason we would want tempestconf configuration separated from tempest one? To me, it's one container thus it kind of makes sense it would be one config file. What happens when the operator will be able to run several containers (probably not at the same time) - tempest, tobiko, rally etc? We will end up with too many config files.
There was a problem hiding this comment.
Not really. To me, it seemed more readable this way but I can see your point. Do you want to update the doc so that we have a single config map?
There was a problem hiding this comment.
@kopecmartin the documentation is updated:)
lpiwowar
force-pushed
the
lpiwowar/feature/python-tempestconf-params
branch
from
f6e4b44 to
91d0790
Compare
This patch introduces tempestconfRun section for the Tempest CR. This field allows a user to specify parameters with which discover-tempest-config should be executed inside the Tempest pod. The documentation is updated as well so that it demonstrates how the new field should be utilized.
This patch introduces a set of parameters for the tempestRun section in the Tempest CR. This field parameters allow a user to specify parameters with which tempest command should be executed inside the Tempest pod. The documentation is updated as well so that it demonstrates how the new field should be utilized.
lpiwowar
force-pushed
the
lpiwowar/feature/python-tempestconf-params
branch
from
91d0790 to
abfc40c
Compare
|
tcib PRs got merged, we can proceed with this one now |
|
/recheck |
|
/lgtm |
lpiwowar
had a problem deploying
to
github-pages
GitHub Actions
Failure
This patch introduces:
tempestconfRun section for the Tempest CR. This field allows a user to specify parameters with which discover-tempest-config should be executed inside the Tempest pod.
a set of parameters for the tempestRun section in the Tempest CR. These new parameters allow a user to specify aruments with which tempest command should be executed inside the Tempest pod.
The documentation is updated as well so that it demonstrates how the new fields should be utilized.