Allow to pass a PV as storage #11
Conversation
This change allows to use an user managed pv to use as results store. We might use different strategies at the end.
| @@ -4,7 +4,7 @@ set -x | |||
| TEMPEST_DIR=$HOME/openshift | |||
| OPERATOR_ETC=/etc/test_operator | |||
| # NOTE: might be backed with a PV | |||
| OUTPUT_PATH=$HOME/output | |||
| OUTPUT_PATH=${TEMPEST_OUTPUTDIR:-$HOME/output} | |||
There was a problem hiding this comment.
@afazekas do we want to still keep the invoke_tempest script? I think we should stick with only one script for tempest execution. And shouldn't we make the same change in the run_tempest.sh in tcib?
There was a problem hiding this comment.
I'm removing the calling of the invoke_tempest script in this PR - maybe I should update the description of the PR. I think we need to agree how we will approach this.
| // +kubebuilder:validation:Optional | ||
| // persistentVolumeClaimVolumeSource represents a reference to a | ||
| // PersistentVolumeClaim in the same namespace. Usable for storing test results. | ||
| PersistentVolumeClaim *corev1.PersistentVolumeClaimVolumeSource `json:"persistentVolumeClaim,omitempty"` |
There was a problem hiding this comment.
This is just an idea. I know that we might be changing this later but don't we want to choose more descriptive name? Something like testResultsPV?
|
A similar issue was already resolved here -> #18. I'm closing this PR for now. If you think I'm wrong then please reopen this PR:). |
This change allows to use an user managed pv to
use as results store.
We might use different strategies at the end.