Add support for tempestconf parameters #95
Conversation
|
Hi @lpiwowar. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Related patch for test-operator: openstack-k8s-operators/test-operator#10 |
|
/ok-to-test |
lpiwowar
force-pushed
the
feature/tempestconf-params
branch
from
c1a0457 to
74139bd
Compare
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a568be34317d4e8c9d9a9c7d401ff4ff ✔️ tcib-build-containers SUCCESS in 2h 13m 53s |
lpiwowar
changed the title
lpiwowar
force-pushed
the
feature/tempestconf-params
branch
from
ac32936 to
74139bd
Compare
lpiwowar
changed the title
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/cb4ac7ffa29246b494e0622930649f94 ✔️ tcib-build-containers SUCCESS in 2h 18m 32s |
|
Thank you for looking at the patch Arx. Yes, I ran the changes locally and they seemed to be working. The options that were hardcoded are still enabled by default (line 10, line 14 and line 46). The only option that was removed is the --os-cloud but I think it should not be a problem as the OS_CLOUD environment variable (which should be detected by python-tempestconf) is defined in the script. |
This patch introduces tempestconf parameters for the tempest container. Currently, it is not possible to specify with what parameters should be discover-tempest-config executed. This patch introduces a set of environment variables prefixed with TEMPESTCONF_ that can be used to tell the container which arguments should be used when executing discover-tempest-config.
lpiwowar
force-pushed
the
feature/tempestconf-params
branch
from
74139bd to
e53be1d
Compare
|
the changes look ok to me and are backwards compatible now |
|
/lgtm |
|
hmm, why it still shows I requested changes? I'd say that should go away after a new commit was proposed (well, force pushed in this case). Hmm, what if I click on Approve changes? Will that make the "Changes requested" message go away or will that merge this? |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/91c2171c911c4a12933222c6b27351c8 ✔️ tcib-build-containers SUCCESS in 2h 09m 21s |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a747b01250694497a8c06c4c960e1822 ❌ tcib-build-containers TIMED_OUT in 50m 50s |
|
recheck |
|
We need to wait for openstack-k8s-operators/ci-framework#785 and #97 to land for passing zuul jobs. |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/c32c542006f7457ab53dd0079f91998d ✔️ tcib-build-containers SUCCESS in 2h 03m 58s |
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/db2b8cab495d42a0b8d5fcea35beebb6 ✔️ tcib-build-containers SUCCESS in 59m 11s |
|
recheck |
|
the CI estimates more then 9 hours till the jobs finish and (maybe) merge this - https://review.rdoproject.org/zuul/status - 9 hours :o so much for shortening the feedback loops :D |
|
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/af2b6f966cf24634aafa736fbae267fb ❌ tcib-build-containers NODE_FAILURE Node request 200-0006656340 failed in 0s |
|
recheck |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kopecmartin, lpiwowar, raukadah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 68057a9
into
openstack-k8s-operators:main
This patch introduces tempestconf parameters for the tempest container. Currently, it is not possible to specify with what parameters should be tempest and discover-tempest-config executed.
This patch introduces a set of environment variables prefixed with TEMPESTCONF_ that can be used to tell the container which arguments should be used when executing discover-tempest-config.