Create all default services #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only creating the default services that are in a NodeSet's Spec.Services, create all default services. Since we support ServicesOverride on a Deployment, we should create all default services in case any of those default services are used on a Deployment but aren't listed in a NodeSet's Spec.Services. This applies directly to the update related services (ovn-update, update) since those are used with ServicesOverride. Jira: https://issues.redhat.com/browse/OSPRH-7957 Signed-off-by: James Slagle <[email protected]>
slagle
force-pushed
the
create-all-default-services
branch
from
8d375d8 to
e47f13d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bshephar, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test openstack-operator-build-deploy-kuttl |
openshift-merge-bot
bot
merged commit 6fa2687
into
openstack-k8s-operators:main
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of only creating the default services that are in a NodeSet's
Spec.Services, create all default services. Since we support
ServicesOverride on a Deployment, we should create all default services
in case any of those default services are used on a Deployment but
aren't listed in a NodeSet's Spec.Services.
This applies directly to the update related services (ovn-update,
update) since those are used with ServicesOverride.
Jira: https://issues.redhat.com/browse/OSPRH-7957
Signed-off-by: James Slagle [email protected]