Create all default services

Instead of only creating the default services that are in a NodeSet's Spec.Services, create all default services. Since we support ServicesOverride on a Deployment, we should create all default services in case any of those default services are used on a Deployment but aren't listed in a NodeSet's Spec.Services. This applies directly to the update related services (ovn-update, update) since those are used with ServicesOverride. Jira: https://issues.redhat.com/browse/OSPRH-7957 Signed-off-by: James Slagle <[email protected]>
openstack-k8s-operators · Jul 1, 2024 · e47f13d · e47f13d
1 parent 8b2b3bf
commit e47f13d
Showing 1 changed file with 0 additions and 11 deletions.
diff --git a/pkg/dataplane/service.go b/pkg/dataplane/service.go
@@ -122,17 +122,6 @@ func EnsureServices(ctx context.Context, helper *helper.Helper, instance *datapl
 			helper.GetLogger().Info("service name must follow RFC1123")
 			return err
 		}
-		nodeSetContainsService := false
-		for _, roleServiceName := range instance.Spec.Services {
-			if roleServiceName == serviceObjMeta.Name {
-				nodeSetContainsService = true
-				break
-			}
-		}
-		if !nodeSetContainsService {
-			helper.GetLogger().Info("Skipping ensure service since it is not a service on this nodeset", "service", serviceObjMeta.Name)
-			continue
-		}
 
 		serviceObjSpec := &dataplanev1.OpenStackDataPlaneServiceSpec{}
 		err = serviceObj.Spec.Decode(serviceObjSpec)