Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openstack_update_run target #843

Merged

Conversation

ciecierski
Copy link
Contributor

@ciecierski ciecierski commented Jun 5, 2024

Add openstack_update_run make target and openstack_update.sh
script which starts openstack minor update on deployed openstack environment.
It starts update by modifying csv of openstack-operator.

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/1749abb75368463688967506a92a545e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 25s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 14m 31s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 14m 36s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 31m 55s
cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 1h 37m 55s

@ciecierski ciecierski force-pushed the update-target branch 2 times, most recently from c0c4c8b to 3e318c7 Compare June 20, 2024 12:49
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a97d4700b02a478fb46ea06a9c0294e2

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 40m 46s
install-yamls-crc-podified-edpm-baremetal RETRY_LIMIT in 8m 19s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 18s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 37m 22s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph SUCCESS in 2h 44m 26s

@ciecierski ciecierski force-pushed the update-target branch 7 times, most recently from 0b33c36 to 031f31e Compare June 25, 2024 06:32
Makefile Outdated Show resolved Hide resolved
@sathlan sathlan self-requested a review June 26, 2024 12:09
scripts/openstack-fake-update.sh Outdated Show resolved Hide resolved
@ciecierski ciecierski changed the title Add openstack_fake_update_run target Add openstack_update_run target Jun 26, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a78d5651b7574d37ac7a25d0b6a4cb5d

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 46s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 12m 40s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 50s
✔️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SUCCESS in 2h 37m 48s
cifmw-data-plane-adoption-osp-17-to-extracted-crc-minimal-no-ceph FAILURE in 2h 04m 30s

@ciecierski ciecierski force-pushed the update-target branch 2 times, most recently from e3ae208 to 38d2cfd Compare June 28, 2024 07:24
Copy link
Contributor

@sathlan sathlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be able to pass variable from and to to the script.

Then there seems to be missing parts:

  1. controller images are not updated
  2. container are not updated on the dataplane

scripts/openstack-update.sh Outdated Show resolved Hide resolved
scripts/openstack-update.sh Outdated Show resolved Hide resolved

if [ ${FAKE_UPDATE} = "true" ]; then
oc get $OPENSTACK_OPERATOR_CSV -o yaml -n $OPERATOR_NAMESPACE > $OUTFILE
sed -i $OUTFILE -e "s|value: .*/podified-antelope-centos9/\(.*\)@.*|value: quay.io/podified-antelope-centos9/\1:current-podified|g"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So two comments here:

  1. we would need to have podified-antelope-centos and current-podified as variables
  2. this doesn't seem to change the operator version in my testing, ie the operators are restarted eventually but they have the same images than when they started:
  # TODO: the openstack-operator
  # OLD:
  # [ospng@lenovo-p720-rdo-07 devsetup]$ grep openstack-opera pods_os_openstack_state_20240626_191654.tsv pods_os_openstack_state_20240627_193513.tsv 
  # pods_os_openstack_state_20240626_191654.tsv:openstack-operator-controller-manager-59cffdd889-wv5l9	2024-06-26T12:59:50Z	gcr.io/kubebuilder/kube-rbac-proxy@sha256:d99a8d144816b951a67648c12c0b988936ccd25cf3754f3cd85ab8c01592248f	2024-06-26T12:59:53Z
  # pods_os_openstack_state_20240626_191654.tsv:openstack-operator-controller-manager-59cffdd889-wv5l9	2024-06-26T12:59:50Z	quay.io/openstack-k8s-operators/openstack-operator@sha256:de33631fbe02967a851252aaf3919f847cac72981e6533d4f46173a80bd9f016	2024-06-26T12:59:58Z
  # pods_os_openstack_state_20240626_191654.tsv:openstack-operator-index-487tb	2024-06-26T12:57:21Z	quay.io/openstack-k8s-operators/openstack-operator-index:latest	2024-06-26T12:57:31Z
  # "NEW":
  # pods_os_openstack_state_20240627_193513.tsv:openstack-operator-controller-manager-5897656d76-5d4f6	2024-06-26T17:26:26Z	gcr.io/kubebuilder/kube-rbac-proxy@sha256:d99a8d144816b951a67648c12c0b988936ccd25cf3754f3cd85ab8c01592248f	2024-06-27T09:18:32Z
  # pods_os_openstack_state_20240627_193513.tsv:openstack-operator-controller-manager-5897656d76-5d4f6	2024-06-26T17:26:26Z	quay.io/openstack-k8s-operators/openstack-operator@sha256:de33631fbe02967a851252aaf3919f847cac72981e6533d4f46173a80bd9f016	2024-06-27T09:18:33Z
  # pods_os_openstack_state_20240627_193513.tsv:openstack-operator-index-487tb	2024-06-26T12:57:21Z	quay.io/openstack-k8s-operators/openstack-operator-index:latest	2024-06-27T09:18:17Z

This is true for all operators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not to test operator updates, but just to test minor openstack update

Copy link

@odyssey4me odyssey4me Jul 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there intention to add a part for the operator update too? Is that going to be a part of this PR or another PR? Is it going to be added to the same make target or a different one?

Copy link
Contributor Author

@ciecierski ciecierski Jul 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update of operator images is not a part of this PR. I see operator images/bundles as different make target. Then there could be another target that combines those two targets into one full end-to-end update run.

scripts/openstack-update.sh Outdated Show resolved Hide resolved
scripts/openstack-update.sh Show resolved Hide resolved
scripts/openstack-update.sh Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Jul 3, 2024
@sathlan sathlan self-requested a review July 4, 2024 07:58
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ciecierski, fao89, sathlan, slagle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cescgina
Copy link
Contributor

cescgina commented Jul 4, 2024

recheck

Add openstack_update_run make target and openstack_update.sh
script which starts openstack minor update on deployed openstack enviroment.
It starts update by patching csv of openstack-operator.
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot added the lgtm label Jul 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit e05abca into openstack-k8s-operators:main Jul 4, 2024
5 checks passed
@ciecierski
Copy link
Contributor Author

/cherry-pick 18.0.0-proposed

@openshift-cherrypick-robot

@ciecierski: new pull request created: #876

In response to this:

/cherry-pick 18.0.0-proposed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants