-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add openstack_update_run target #843
Add openstack_update_run target #843
Conversation
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/1749abb75368463688967506a92a545e ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 25s |
c0c4c8b
to
3e318c7
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a97d4700b02a478fb46ea06a9c0294e2 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 40m 46s |
0b33c36
to
031f31e
Compare
031f31e
to
a1a59c1
Compare
Build failed (check pipeline). Post https://review.rdoproject.org/zuul/buildset/a78d5651b7574d37ac7a25d0b6a4cb5d ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 15m 46s |
e3ae208
to
38d2cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be able to pass variable from and to to the script.
Then there seems to be missing parts:
- controller images are not updated
- container are not updated on the dataplane
scripts/openstack-update.sh
Outdated
|
||
if [ ${FAKE_UPDATE} = "true" ]; then | ||
oc get $OPENSTACK_OPERATOR_CSV -o yaml -n $OPERATOR_NAMESPACE > $OUTFILE | ||
sed -i $OUTFILE -e "s|value: .*/podified-antelope-centos9/\(.*\)@.*|value: quay.io/podified-antelope-centos9/\1:current-podified|g" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So two comments here:
- we would need to have podified-antelope-centos and current-podified as variables
- this doesn't seem to change the operator version in my testing, ie the operators are restarted eventually but they have the same images than when they started:
# TODO: the openstack-operator
# OLD:
# [ospng@lenovo-p720-rdo-07 devsetup]$ grep openstack-opera pods_os_openstack_state_20240626_191654.tsv pods_os_openstack_state_20240627_193513.tsv
# pods_os_openstack_state_20240626_191654.tsv:openstack-operator-controller-manager-59cffdd889-wv5l9 2024-06-26T12:59:50Z gcr.io/kubebuilder/kube-rbac-proxy@sha256:d99a8d144816b951a67648c12c0b988936ccd25cf3754f3cd85ab8c01592248f 2024-06-26T12:59:53Z
# pods_os_openstack_state_20240626_191654.tsv:openstack-operator-controller-manager-59cffdd889-wv5l9 2024-06-26T12:59:50Z quay.io/openstack-k8s-operators/openstack-operator@sha256:de33631fbe02967a851252aaf3919f847cac72981e6533d4f46173a80bd9f016 2024-06-26T12:59:58Z
# pods_os_openstack_state_20240626_191654.tsv:openstack-operator-index-487tb 2024-06-26T12:57:21Z quay.io/openstack-k8s-operators/openstack-operator-index:latest 2024-06-26T12:57:31Z
# "NEW":
# pods_os_openstack_state_20240627_193513.tsv:openstack-operator-controller-manager-5897656d76-5d4f6 2024-06-26T17:26:26Z gcr.io/kubebuilder/kube-rbac-proxy@sha256:d99a8d144816b951a67648c12c0b988936ccd25cf3754f3cd85ab8c01592248f 2024-06-27T09:18:32Z
# pods_os_openstack_state_20240627_193513.tsv:openstack-operator-controller-manager-5897656d76-5d4f6 2024-06-26T17:26:26Z quay.io/openstack-k8s-operators/openstack-operator@sha256:de33631fbe02967a851252aaf3919f847cac72981e6533d4f46173a80bd9f016 2024-06-27T09:18:33Z
# pods_os_openstack_state_20240627_193513.tsv:openstack-operator-index-487tb 2024-06-26T12:57:21Z quay.io/openstack-k8s-operators/openstack-operator-index:latest 2024-06-27T09:18:17Z
This is true for all operators.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not to test operator updates, but just to test minor openstack update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there intention to add a part for the operator update too? Is that going to be a part of this PR or another PR? Is it going to be added to the same make target or a different one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update of operator images is not a part of this PR. I see operator images/bundles as different make target. Then there could be another target that combines those two targets into one full end-to-end update run.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ciecierski, fao89, sathlan, slagle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
recheck |
Add openstack_update_run make target and openstack_update.sh script which starts openstack minor update on deployed openstack enviroment. It starts update by patching csv of openstack-operator.
New changes are detected. LGTM label has been removed. |
e05abca
into
openstack-k8s-operators:main
/cherry-pick 18.0.0-proposed |
@ciecierski: new pull request created: #876 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Add openstack_update_run make target and openstack_update.sh
script which starts openstack minor update on deployed openstack environment.
It starts update by modifying csv of openstack-operator.