Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Document, add ID_STAGE description #1832

Merged

Conversation

JeanRochCoulon
Copy link
Contributor

Add chapters corresponding to the N-1 CVA6 hierarchy.
Add block diagrams.
Add ID_STAGE first description, to be fine-tuned.

Copy link
Contributor

❌ failed run, report available here.

Copy link
Contributor

@jquevremont jquevremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the huge effort. Very minor comments (no need for me to re-review).

The compressed_decoder module decompresses all the compressed
instructions taking a 16-bit compressed instruction and expanding it
to its 32-bit equivalent.
All compressed instructions have a 32-bit equivalent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true with CVA6 (so no change is required).
FYI: This is no more true globally for the RISC-V ISA as the Zcmp extension includes instructions like push and pop that are expanded as series of 32-bit instructions. And Zcmt instructions have no equivalent 32-bits instructions.



----------------------
Memory Management Unit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MMU in the embedded CV32A65X?
FYI, PlanV is upgrading the MMU documentation to expand with Sv39 and and Sv39x4, as part of the MMU unification.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MMU removed from 65X DD

@@ -26,7 +26,12 @@ At least 6 cycles are needed to execute one instruction.
Connection with other sub-systems
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At line 18, missing period at the end of the sentence.
At line 21 "The processor is single issue", no more true for CV32A65X.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback, I will fix in a next PR.

@@ -15,7 +15,7 @@
* - Signal
- IO
- Description
- Connection
- connexion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Connexion" in French, "connection" in English. This is counter-intuitive.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oeufs corses ! Fixed

Copy link
Contributor

✔️ successful run, report available here.

@JeanRochCoulon JeanRochCoulon merged commit b4c287a into openhwgroup:master Feb 16, 2024
19 checks passed
@JeanRochCoulon JeanRochCoulon deleted the DD_architecture branch February 16, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants