-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design Document, add ID_STAGE description #1832
Design Document, add ID_STAGE description #1832
Conversation
❌ failed run, report available here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the huge effort. Very minor comments (no need for me to re-review).
The compressed_decoder module decompresses all the compressed | ||
instructions taking a 16-bit compressed instruction and expanding it | ||
to its 32-bit equivalent. | ||
All compressed instructions have a 32-bit equivalent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true with CVA6 (so no change is required).
FYI: This is no more true globally for the RISC-V ISA as the Zcmp extension includes instructions like push and pop that are expanded as series of 32-bit instructions. And Zcmt instructions have no equivalent 32-bits instructions.
|
||
|
||
---------------------- | ||
Memory Management Unit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MMU in the embedded CV32A65X?
FYI, PlanV is upgrading the MMU documentation to expand with Sv39 and and Sv39x4, as part of the MMU unification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MMU removed from 65X DD
@@ -26,7 +26,12 @@ At least 6 cycles are needed to execute one instruction. | |||
Connection with other sub-systems |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At line 18, missing period at the end of the sentence.
At line 21 "The processor is single issue", no more true for CV32A65X.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I will fix in a next PR.
@@ -15,7 +15,7 @@ | |||
* - Signal | |||
- IO | |||
- Description | |||
- Connection | |||
- connexion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Connexion" in French, "connection" in English. This is counter-intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oeufs corses ! Fixed
✔️ successful run, report available here. |
Add chapters corresponding to the N-1 CVA6 hierarchy.
Add block diagrams.
Add ID_STAGE first description, to be fine-tuned.