Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#508] [#507] Add Unit Test for Network Layer #526

Merged
merged 5 commits into from
Oct 9, 2023
Merged

[#508] [#507] Add Unit Test for Network Layer #526

merged 5 commits into from
Oct 9, 2023

Conversation

blyscuit
Copy link
Collaborator

@blyscuit blyscuit commented Oct 4, 2023 •
edited
Loading

What happened 👀

Add NetworkAPI tests to improve project's test coverage.

Insight 📝

  • Add OHTTPStub to stub data for the API.
  • Create DummyAPIModel and DummyRequestConfiguration to use for the test.
  • There is only one network layer with async await for both UI Interfaces.

Proof Of Work 📹

Screenshot 2023-10-04 at 18 02 58

@blyscuit blyscuit self-assigned this Oct 4, 2023
@blyscuit blyscuit modified the milestones: 4.8.0, 4.9.0 Oct 4, 2023
@nkhanh44 nkhanh44 force-pushed the chore/#515-remove-rxswift-and-its-libs branch from 670ef6b to 034edae Compare October 5, 2023 02:03
@blyscuit blyscuit force-pushed the feature/#508-swiftui-network-unit-test branch from 03e2d51 to 7e653b9 Compare October 5, 2023 02:22
@blyscuit blyscuit changed the title [#508] Add network test [#508] Add Unit Test for Network Layer Oct 5, 2023
@blyscuit blyscuit marked this pull request as ready for review October 5, 2023 08:33
Base automatically changed from chore/#515-remove-rxswift-and-its-libs to develop October 5, 2023 10:42
@blyscuit blyscuit force-pushed the feature/#508-swiftui-network-unit-test branch from 9bd2750 to be01e39 Compare October 6, 2023 04:18
@blyscuit blyscuit added this pull request to the merge queue Oct 9, 2023
Merged via the queue into develop with commit d10fa8b Oct 9, 2023
4 checks passed
@blyscuit blyscuit deleted the feature/#508-swiftui-network-unit-test branch October 9, 2023 07:43
@blyscuit
Copy link
Collaborator Author

blyscuit commented Oct 9, 2023

Early merge to fix issue with cocoapods.

@blyscuit blyscuit changed the title [#508] Add Unit Test for Network Layer [#508] [#507] Add Unit Test for Network Layer Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhanh44 nkhanh44 nkhanh44 approved these changes

@Thieurom Thieurom Thieurom approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

Assignees

@blyscuit blyscuit

Labels
type : feature
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blyscuit @Thieurom @nkhanh44