Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 4.9.0 #535

Merged
merged 27 commits into from
Oct 31, 2023
Merged

Release - 4.9.0 #535

merged 27 commits into from
Oct 31, 2023

Conversation

blyscuit
Copy link
Collaborator

@blyscuit blyscuit commented Oct 17, 2023 •
edited
Loading

blyscuit and others added 25 commits September 28, 2023 11:35
@blyscuit
[#495] Add Swift package for Make
4cf4cbb
@blyscuit
[#495] Modify readme for Swift command
0c2d1d4
@blyscuit
[#495] Add helper for Env
0e72643
@blyscuit
[#495] Remove template workflows when using template
3fcb789
@blyscuit
[#495] Fix uikit script
a5dd60b
@blyscuit
[#495] Fix interface script
87b99d8
@blyscuit
[#495] Fix removal script
a7b948a
@blyscuit
[#495] Skip Rename swift build
6a8546d
@blyscuit
[#495] Skip Rename png
e3fb966
@blyscuit
Merge pull request #514 from nimblehq/feature/#495-package-setup-swif…
afedd78 
…t-command

[#495] Package all Swift Commands
@nkhanh44
[#515] Remove all Rx things
07ea0ff
@nkhanh44
[#515] Add asyn await to network layer
78dafeb
@nkhanh44
[#515] Refactor NetworkAPIProtocol
1f226eb
@nkhanh44
[#515] Refactor NetworkAPIProtocol and move them to shared folder
034edae
@blyscuit
Merge pull request #525 from nimblehq/chore/#515-remove-rxswift-and-i…
94b3a23 
…ts-libs

[#515] Remove all Rx things
@blyscuit
[#508] Add network test
6658c62
@blyscuit
[#508] Update Quick and Nimble to support Async
d917c57
@blyscuit
[#508] Add folder for Data layer Dummy
7151ff8
@blyscuit
[#508] Fix build Rx
be01e39
@blyscuit
[#530] Fix build
fa5826a
@blyscuit
Merge pull request #526 from nimblehq/feature/#508-swiftui-network-un…
d10fa8b 
…it-test

[#508] Add Unit Test for Network Layer
@blyscuit
[#482] Update Quick and Nimble with better support for async
ed8c984
@blyscuit
[#482] Update KIF
d2905e6
@blyscuit
[#482] Update Async spec
3b6e33a
@blyscuit
Merge pull request #527 from nimblehq/feature/#482-upgrade-quick-nimble
325657d 
[#482] Migrate Quick/Nimble tests to Quick 7
@blyscuit blyscuit self-assigned this Oct 17, 2023
@blyscuit blyscuit added this to the 4.9.0 milestone Oct 17, 2023
@blyscuit blyscuit marked this pull request as ready for review October 31, 2023 02:23
@blyscuit
Merge pull request #537 from nimblehq/feature/478-add-swift-lint-rule…
5f80dc3 
…-implicit-return-one-line

[#487] Update swiftlint implicit_return rule
@blyscuit
Copy link
Collaborator Author

blyscuit commented Oct 31, 2023 •
edited
Loading

Fine to ignore TestFlight workflow. Failed because build version duplicate. We had many commits recently.

@blyscuit blyscuit merged commit 17a097b into main Oct 31, 2023
1 of 2 checks passed
@blyscuit blyscuit deleted the release/4.9.0 branch October 31, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkhanh44 nkhanh44 nkhanh44 approved these changes

@ducbm051291 ducbm051291 ducbm051291 approved these changes

@phongvhd93 phongvhd93 phongvhd93 approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

Assignees

@blyscuit blyscuit

Labels
type : release
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@blyscuit @phongvhd93 @ducbm051291 @nkhanh44