Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release - 4.8.0 #523

Merged
merged 20 commits into from
Sep 13, 2023
Merged

Release - 4.8.0 #523

merged 20 commits into from
Sep 13, 2023

Conversation

blyscuit
Copy link
Collaborator

@blyscuit blyscuit commented Sep 7, 2023 •
edited
Loading

blyscuit and others added 20 commits August 4, 2023 17:49
@blyscuit
[#494] Add SetUpiOSProject.swift. Move SetUpInterface to struct
68d7f93
@blyscuit
[#494] Add renaming to SetUpiOSProject.swift
508a9df
@blyscuit
[#494] Add extra scripts to main set up
f9117bf
@blyscuit
[#494] Refactor funcs
20759d8
@blyscuit
[#494] Add filter for unnessary files
4975f20
@blyscuit
[#494] Add filter for unnessary files
6a104b7
@blyscuit
[#494] Fix Danger import old files
6fab661
@ducbm051291
[#492] Create SetUpTestTestFlight.swift
cba1e35 
Remove set_up_test_test_flight.sh
Update workflow to use the SetUpTestTestFlight.swift
@blyscuit
Merge pull request #512 from nimblehq/chore/492-migrate-set-up-test-t…
82fd58b 
…est-flight-to-swift-command

[#492] Migrate set_up_test_testflight.sh to Swift command
@blyscuit
[#494] Fix comment
f94af58
@blyscuit
Merge pull request #504 from nimblehq/chore/494-make-sh-swift-command
00e6deb 
[#494] Migrate make.sh to Swift command
@vnntsu @ducbm051291
Revert "[Chore] [#423] Update a specific name for deploying staging b…
c474f72 
…uild to firebase workflow"
@nkhanh44 @ducbm051291
[#423] Update names for workflows and their descriptions
123118f
@ducbm051291
[#510] Add function remove in Keychain to remove keychain in case the…
fa4a681 
… runner is self-hosted

Add new fastlane lane removeKeychain
Add remove keychain step in github action workflow
Add continue-on-error: true for step remove keychain
@ducbm051291
[#510] Clean up unused code
71ef49a
@ducbm051291
[#510] Update keychainName default value with "{PROJECT_NAME}" to be …
c37549f 
…replaced when run make.sh

Update make.sh to accept minimum-version
@ducbm051291
[#510] Update keychainName default value
3e873f8
@Shayokh144
[fix] [517] Fix crash by setting appropriate string
07ef7e5
@blyscuit
Merge pull request #513 from nimblehq/feature/510-github-actions-can-…
81d9e23 
…remove-custom-keychain-when-needed

[#510] GitHub actions can remove custom keychain when needed
@blyscuit
Merge pull request #520 from nimblehq/bug/517-fix-ui-test-crash
3449d97 
[#517] Fix: UI test crashed in initial run for SwiftUI project
@blyscuit blyscuit self-assigned this Sep 7, 2023
@blyscuit blyscuit added this to the 4.8.0 milestone Sep 7, 2023
@blyscuit blyscuit marked this pull request as ready for review September 7, 2023 06:02
@blyscuit blyscuit merged commit aa841f7 into main Sep 13, 2023
@blyscuit blyscuit deleted the release/4.8.0 branch September 13, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducbm051291 ducbm051291 ducbm051291 approved these changes

@Thieurom Thieurom Thieurom approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@blyscuit blyscuit

Labels
type : release
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@blyscuit @Thieurom @ducbm051291 @vnntsu @nkhanh44 @Shayokh144