Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#515] Remove all Rx things #525

Merged
merged 4 commits into from
Oct 5, 2023
Merged

[#515] Remove all Rx things #525

merged 4 commits into from
Oct 5, 2023

Conversation

nkhanh44
Copy link
Contributor

@nkhanh44 nkhanh44 commented Sep 29, 2023 •
edited
Loading

What happened 👀

  • Removed RxNimble, RxSwift, RxDataSources, RxCocoa, and RxAlamofire.
  • Added Alamofire, JSONAPIMapper.
  • Updated NetworkAPIProtocol, and NetworkAPI to the Combine version.

Insight 📝

  • N/a

Proof Of Work 📹

  • No more Rx search found
  • Test SwiftUI and UIKit Install Script / Test (push) are all successful

@nkhanh44 nkhanh44 force-pushed the chore/#515-remove-rxswift-and-its-libs branch from 9985e09 to 3dcd29b Compare September 29, 2023 02:53
@nkhanh44 nkhanh44 self-assigned this Sep 29, 2023
@nkhanh44 nkhanh44 linked an issue Sep 29, 2023 that may be closed by this pull request
Remove RxSwift and its libraries for UIKit variant #515
Closed
@nkhanh44 nkhanh44 marked this pull request as ready for review September 29, 2023 03:30
blyscuit
blyscuit reviewed Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@blyscuit blyscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if we should update SwiftUI with Async too 🤔

@nkhanh44 nkhanh44 requested a review from suho October 3, 2023 05:06
@suho
Copy link
Member

suho commented Oct 3, 2023

@blyscuit For Tuist/Interfaces, we should focus on Presentation Layer only, Data and Domain could be shared

@blyscuit
Copy link
Collaborator

blyscuit commented Oct 3, 2023 •
edited
Loading

@suho @nkhanh44 I meant this files and the children 🙏 We can probably remove it because now they can be shared 🤔
So we can move the file in this PR back to Project/Sources/Data.

@suho
Copy link
Member

suho commented Oct 3, 2023

@blyscuit Yes, we can move it back to Project/Sources/Data

@nkhanh44 nkhanh44 force-pushed the chore/#515-remove-rxswift-and-its-libs branch from 670ef6b to 034edae Compare October 5, 2023 02:03
@blyscuit blyscuit added this to the 4.9.0 milestone Oct 5, 2023
@blyscuit blyscuit added this pull request to the merge queue Oct 5, 2023
Merged via the queue into develop with commit 94b3a23 Oct 5, 2023
4 checks passed
@blyscuit blyscuit deleted the chore/#515-remove-rxswift-and-its-libs branch October 5, 2023 10:42
This was referenced Oct 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suho suho suho approved these changes

@Thieurom Thieurom Thieurom approved these changes

@blyscuit blyscuit blyscuit approved these changes

@markgravity markgravity Awaiting requested review from markgravity markgravity is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@ducbm051291 ducbm051291 Awaiting requested review from ducbm051291 ducbm051291 is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

Assignees

@nkhanh44 nkhanh44

Labels
type : chore
Projects
None yet
Milestone
4.9.0
Development

Successfully merging this pull request may close these issues.

Remove RxSwift and its libraries for UIKit variant
4 participants
@nkhanh44 @suho @blyscuit @Thieurom