Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcListItem): change padding for one-line layout #5391

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Mar 11, 2024

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot from 2024-03-11 10-52-43 Screenshot from 2024-03-11 10-51-21

🚧 Tasks

  • ...

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@GretaD GretaD added 3. to review Waiting for reviews feature: list-item Related to the list-item component labels Mar 11, 2024
@GretaD GretaD requested review from ChristophWurst and st3iny March 11, 2024 09:54
@GretaD GretaD self-assigned this Mar 11, 2024
@GretaD GretaD added the enhancement New feature or request label Mar 11, 2024
@susnux
Copy link
Contributor

susnux commented Mar 11, 2024

Is this not covered by the compact mode?

@GretaD
Copy link
Contributor Author

GretaD commented Mar 11, 2024

/backport to next

@GretaD
Copy link
Contributor Author

GretaD commented Mar 11, 2024

Is this not covered by the compact mode?

no, its not showing if i dont add this. Do i need to change something else on my end?

@GretaD GretaD merged commit 5b8d393 into master Mar 11, 2024
18 checks passed
@GretaD GretaD deleted the fix/one-line-hover-padding branch March 11, 2024 14:52
Copy link

backportbot bot commented Mar 11, 2024

The backport to next failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout next
git pull origin next

# Create the new backport branch
git checkout -b backport/5391/next

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2be5eb6d

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5391/next

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@ShGKme ShGKme added bug Something isn't working and removed enhancement New feature or request labels Mar 11, 2024
@ShGKme ShGKme changed the title NcListItem - change padding for one-line layout fix(NcListItem): change padding for one-line layout Mar 11, 2024
@ShGKme ShGKme mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug Something isn't working feature: list-item Related to the list-item component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants