-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NcListItem): change padding for one-line layout #5391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: greta <[email protected]>
GretaD
added
3. to review
Waiting for reviews
feature: list-item
Related to the list-item component
labels
Mar 11, 2024
2 tasks
Is this not covered by the compact mode? |
/backport to next |
no, its not showing if i dont add this. Do i need to change something else on my end? |
ChristophWurst
approved these changes
Mar 11, 2024
susnux
approved these changes
Mar 11, 2024
The backport to # Switch to the target branch and update it
git checkout next
git pull origin next
# Create the new backport branch
git checkout -b backport/5391/next
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2be5eb6d
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5391/next Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
ShGKme
added
bug
Something isn't working
and removed
enhancement
New feature or request
labels
Mar 11, 2024
ShGKme
changed the title
NcListItem - change padding for one-line layout
fix(NcListItem): change padding for one-line layout
Mar 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
bug
Something isn't working
feature: list-item
Related to the list-item component
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
next
requested with a Vue 3 upgrade