-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to change mail list view into full width #9285
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Noticed during testing
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 1. There are two scroll bars when using list layout.
- 2. Scrolling to load more doesn't work on portrait screens
- This is a know and wont-fix bug of the old layout as well. We just hide it by loading enough messages so that the list is always scrollable. Now, the list fits more items so we should increase the amount of initial envelopes a bit in list mode.
About 1.)
03d3241
to
973da14
Compare
Current state not indicate, Maybe it should be like this? Horizontal is also possible
|
Has #9285 (review) been addressed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works
Looks great. Works on desktop and mobile 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i will do this in a follow up pr, after the horizontal layout is in as well, because for sure it will need some changes there too |
98824b4
to
1dd4f47
Compare
Signed-off-by: greta <[email protected]>
534ef47
to
f509bf6
Compare
Fix #8811