Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to change mail list view into full width #9285

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

src/components/EnvelopeList.vue Outdated Show resolved Hide resolved
src/store/actions.js Outdated Show resolved Hide resolved
src/store/actions.js Outdated Show resolved Hide resolved
src/store/mutations.js Outdated Show resolved Hide resolved
src/store/getters.js Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
@GretaD GretaD changed the title Add the possibility to change mail list view into full width or up bottom Add the possibility to change mail list view into full width Feb 23, 2024
@GretaD

This comment was marked as outdated.

@ChristophWurst
Copy link
Member

ChristophWurst commented Mar 4, 2024

Noticed during testing

  • Back button always causes the envelope list to reload. This seems unnecessary and makes interactions slow.
  • Sidebar toggle and back button have inconsistent color (black vs gray) and do not align horizontally.
  • Important icon is broken in list mode
  • The clickable area and hover area of envelopes is small in list mode. Increase padding and reduce margin at the same rate to make the elements bigger without taking more space.

Other

  • Subject/preview is not styled as columns. The longer the subject, the less I see of the preview. This is by design spec but it looks strange.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1. There are two scroll bars when using list layout.
  • 2. Scrolling to load more doesn't work on portrait screens
    • This is a know and wont-fix bug of the old layout as well. We just hide it by loading enough messages so that the list is always scrollable. Now, the list fits more items so we should increase the amount of initial envelopes a bit in list mode.

About 1.)

grafik

src/components/Envelope.vue Outdated Show resolved Hide resolved
src/components/Envelope.vue Outdated Show resolved Hide resolved
@hamza221
Copy link
Contributor

hamza221 commented Mar 11, 2024

Current state not indicate, Maybe it should be like this? Horizontal is also possible

B A
image image

@ChristophWurst
Copy link
Member

Has #9285 (review) been addressed?

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works

Looks great. Works on desktop and mobile 👍

src/components/AppSettingsMenu.vue Outdated Show resolved Hide resolved
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more double scrolling bar 👍

image

whitespace on top of thread header can be improved

@ChristophWurst
Copy link
Member

:shipit:

@GretaD
Copy link
Contributor Author

GretaD commented Mar 12, 2024

whitespace on top of thread header can be improved

i will do this in a follow up pr, after the horizontal layout is in as well, because for sure it will need some changes there too

@GretaD GretaD force-pushed the feat/horizontal-view-2 branch from 98824b4 to 1dd4f47 Compare March 12, 2024 11:29
@ChristophWurst ChristophWurst force-pushed the feat/horizontal-view-2 branch from 534ef47 to f509bf6 Compare March 12, 2024 18:27
@ChristophWurst ChristophWurst merged commit 7460d07 into main Mar 12, 2024
36 of 37 checks passed
@ChristophWurst ChristophWurst deleted the feat/horizontal-view-2 branch March 12, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full-width mail list
4 participants