-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next] fix(NcListItem): bring back old styling for two-line list items #5476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot
bot
added
bug
Something isn't working
3. to review
Waiting for reviews
regression
Regression of a previous working feature
feature: list-item
Related to the list-item component
labels
Apr 10, 2024
Covered by #5446 |
That one conflicts a lot it would be easier to first try to merge all manually backports then I rebase for the remaining part. As far as I can see this one should be good? |
susnux
reviewed
Apr 10, 2024
susnux
approved these changes
Apr 10, 2024
Signed-off-by: Maksim Sukharev <[email protected]>
susnux
force-pushed
the
backport/5400/next
branch
from
April 10, 2024 18:40
63d571f
to
0bf574f
Compare
Signed-off-by: Eduardo Morales <[email protected]>
Signed-off-by: Eduardo Morales <[email protected]>
- fix issues, when details are not provided Signed-off-by: Maksim Sukharev <[email protected]>
…name Signed-off-by: Maksim Sukharev <[email protected]>
Signed-off-by: greta <[email protected]>
emoral435
reviewed
Apr 13, 2024
susnux
approved these changes
Apr 19, 2024
emoral435
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
bug
Something isn't working
feature: list-item
Related to the list-item component
regression
Regression of a previous working feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #5388
Backport of PR #5391
Backport of PR #5400
Backport of PR #5408
Backport of PR #5421
master