Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next] fix(NcListItem): bring back old styling for two-line list items #5476

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Apr 10, 2024

Backport of PR #5388
Backport of PR #5391
Backport of PR #5400
Backport of PR #5408
Backport of PR #5421

Diff with master Migration to Vue 3 commit
image image

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews regression Regression of a previous working feature feature: list-item Related to the list-item component labels Apr 10, 2024
@Antreesy
Copy link
Contributor

Covered by #5446

@Antreesy Antreesy closed this Apr 10, 2024
@susnux susnux reopened this Apr 10, 2024
@susnux
Copy link
Contributor

susnux commented Apr 10, 2024

Covered by #5446

That one conflicts a lot it would be easier to first try to merge all manually backports then I rebase for the remaining part.

As far as I can see this one should be good?

@susnux susnux force-pushed the backport/5400/next branch from 63d571f to 0bf574f Compare April 10, 2024 18:40
@Antreesy Antreesy requested review from emoral435 and susnux April 11, 2024 19:34
@Antreesy Antreesy requested a review from emoral435 April 19, 2024 06:09
@Antreesy Antreesy merged commit 2d9e6eb into next Apr 20, 2024
17 checks passed
@Antreesy Antreesy deleted the backport/5400/next branch April 20, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: list-item Related to the list-item component regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants