Modernise Angular frontend, remove frontpage, remove Nebular #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
refactor/frontend-cleanup
branch
6 times, most recently
from
7338a17 to
ed8c6cc
Compare
|
Sorry, I wanted to get those last big Nx refactors in their own PR, but some weird issue with building one of the backend libraries was failing CI on this PR, and doing that big Nx refactor fixed it, so I just bunged it into this one. Soz!! |
tsa96
force-pushed
the
refactor/frontend-cleanup
branch
4 times, most recently
from
bc17c39 to
d444885
Compare
GordiNoki
reviewed
Jan 3, 2024
GordiNoki
reviewed
Jan 3, 2024
GordiNoki
reviewed
Jan 3, 2024
.../src/app/components/map-testing-request-selection/map-testing-request-selection.component.ts
Outdated
Show resolved
Hide resolved
GordiNoki
reviewed
Jan 4, 2024
GordiNoki
requested changes
Jan 4, 2024
Gocnak
requested changes
Jan 6, 2024
|
WRT the XP systems stuff, I misunderstood the old cosmetic XP code, so the issue and previous PR from @ianwillis98 were actually incorrect - completely my fault, sorry about that. Going to drop the XP related stuff from this PR, and fix everything in a separate branch. |
are you okay?? is review that bad??? |
byeeeeeeee
FUCKING FINALLY!!
This actually breaks Nebular overlays but I'm so sick of Nebular I'm gonna try replace them with PrimeNG stuff right now
These changes are messy but helpful to split these commits up. This is just the result of running `@angular/core:standalone` scripts, then format/linting.
There's literally nothing in this, and with standalone components removing all the excess fluff, I just don't see the reason to keep this stubbed - there's barely anything to keep!
Don't really have a use for this, and I want to bring the Frontend Nx libraries into the main app soon anyway.
Having stuff in separate libraries by packed into modules simplifies imports a little, not much benefit to keeping standalone
Just another thing I don't wanna use lodash for
There's nothing managed by Nx in here, so pointless having it be in a separate library.
IMO this isn't justified in having a dedicated page, moving to homepage in next community.
Tailwind + CSS Grid :D
When this was a separate library having a module made some sense, but standalone is probably a bit better now. (Change to remove PipesModule was in last commit, annoying to dig it out, sorry!)
This converts everything over to Angular 17's new control flow. I don't love the extra indentation, but in most cases it's a big improvement and worth moving to this entirely for sake of consistency IMO
This is just the result of running https://github.com/import-js/eslint-plugin-import with the `order` rule enabled. I think it's too annoying to enforce as an overall rule. But running it the once to get existing stuff cleaned up seems okay, whilst I'm moving a bunch of other files around anyway.
Doesn't *actually* work, since LocalUserService errors make the test fail. No point fixing those til we support accessing the dashboard without a login though.
This is barely doing anything right now since we don't have any frontend e2e tests. Since I removed the main page, we can no longer just test that, and without a JWT the dashboard will try to redirect you to Steam, or spit out errors. We could generate logins and stuff relatively easily, but I just don't want to work on it for now. So I'm disabling this task until we do the auth-less stuff, or major new Cypress stuff.
tsa96
force-pushed
the
refactor/frontend-cleanup
branch
from
cedd59e to
1661a38
Compare
GordiNoki
approved these changes
Jan 7, 2024
Gocnak
approved these changes
Jan 7, 2024
|
Excellent work Tom, the site is looking amazing. |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes removes Nebular (closes #865), replacing some components with PrimeNG, others with custom ones I made.
Also,
This is a big PR, but it took a huge amount of work to clean up the 2018 crap. There's still some there, but most stuff is far far nicer to work on.