Skip to content

Commit

Permalink
ci(front-e2e): disable frontend e2e
Browse files Browse the repository at this point in the history
This is barely doing anything right now since we don't have any frontend e2e tests.
Since I removed the main page, we can no longer just test that, and without a JWT
the dashboard will try to redirect you to Steam, or spit out errors.
We could generate logins and stuff relatively easily, but I just don't want to work
on it for now. So I'm disabling this task until we do the auth-less stuff, or major
new Cypress stuff.
  • Loading branch information
tsa96 committed Jan 1, 2024
1 parent d61171c commit bc17c39
Showing 1 changed file with 37 additions and 35 deletions.
72 changes: 37 additions & 35 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -135,38 +135,40 @@ jobs:
docker compose
-f docker-compose.yml -f docker-compose.test.yml
run backend-e2e
frontend-e2e:
name: Frontend E2E Tests
runs-on: ubuntu-latest
needs: install-deps
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.event.pull_request.head.ref }}
repository: ${{ github.event.pull_request.head.repo.full_name }}
fetch-depth: 0
submodules: 'true'
- name: Cache node_modules
uses: actions/cache@v3
with:
path: node_modules
key: modules-${{ github.run_id }}
- name: Check affected
run:
|
if npx nx show projects \
--affected \
--base=${{ github.event.pull_request.base.sha }} \
--head=${{ github.event.pull_request.head.sha }} |
grep -q frontend-e2e
then
echo "affected=true" >> $GITHUB_ENV
else
echo "affected=false" >> $GITHUB_ENV
fi
- name: Run tests in Docker
if: env.affected == 'true'
run:
docker compose
-f docker-compose.yml -f docker-compose.test.yml
run frontend-e2e
# Disabled until we allow using this site without a Steam login
# https://github.com/momentum-mod/website/issues/878
# frontend-e2e:
# name: Frontend E2E Tests
# runs-on: ubuntu-latest
# needs: install-deps
# steps:
# - uses: actions/checkout@v3
# with:
# ref: ${{ github.event.pull_request.head.ref }}
# repository: ${{ github.event.pull_request.head.repo.full_name }}
# fetch-depth: 0
# submodules: 'true'
# - name: Cache node_modules
# uses: actions/cache@v3
# with:
# path: node_modules
# key: modules-${{ github.run_id }}
# - name: Check affected
# run:
# |
# if npx nx show projects \
# --affected \
# --base=${{ github.event.pull_request.base.sha }} \
# --head=${{ github.event.pull_request.head.sha }} |
# grep -q frontend-e2e
# then
# echo "affected=true" >> $GITHUB_ENV
# else
# echo "affected=false" >> $GITHUB_ENV
# fi
# - name: Run tests in Docker
# if: env.affected == 'true'
# run:
# docker compose
# -f docker-compose.yml -f docker-compose.test.yml
# run frontend-e2e

0 comments on commit bc17c39

Please sign in to comment.