Revert XP constant changes #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gocnak
approved these changes
Jan 7, 2024
tsa96
force-pushed
the
fix/xp-constants
branch
from
5357ff9 to
4414a1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split these changes out from #876 so we can review separately. Sorry that it's still on top of all those commits, some file renaming/moving requires it, this branch is really just the last two commits!
So, I completely misunderstood how new user cosmetic XP/level assignment worked, getting the wrong impression that new users were supposed to start at 20,000 XP. This was completely my own fault, I ported some of the initial XP systems code from the old backend wrong, and assumed the weird behaviour was a result of the original design, not my own crappy porting. Apologies for that! This reverts to the original constants, and starts new users with the correct starting values of level 1, 0 XP. I don't test that directly, but hopefully @ianwillis98 or whoever ends up doing #868 can do checks in there.
Also, having dug up the original spreadsheet to the cosmetic XP stuff, I wrote some unit tests for those values. Don't worry, the Google sheets URL in the comment is view-only.