Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add 3 builtin roles #28961

Merged
merged 1 commit into from
Dec 18, 2023
Merged

enhance: add 3 builtin roles #28961

merged 1 commit into from
Dec 18, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 4, 2023 •
edited
Loading

issue: #28960 milvus-proto #212 #29243

add new configuration: builtinRoles
user can define roles in config file: milvus.yaml

there is an example:

  1. db_ro, only have read privileges, include load
  2. db_rw, read and write privileges, include create/drop/rename collection
  3. db_admin, not only read and write privileges, but also user administration

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 4, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #28961 (30d1127) into master (3f7d636) will increase coverage by 0.00%.
Report is 4 commits behind head on master.
The diff coverage is 86.36%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #28961    +/-   ##
========================================
  Coverage   82.04%   82.04%            
========================================
  Files         862      863     +1     
  Lines      122394   122502   +108     
========================================
+ Hits       100420   100509    +89     
- Misses      18642    18660    +18     
- Partials     3332     3333     +1
Files Coverage Δ
internal/proxy/privilege_interceptor.go 76.72% <100.00%> (ø)
pkg/util/constant.go 82.85% <100.00%> (+3.54%) ⬆️
pkg/util/funcutil/func.go 88.49% <100.00%> (+1.15%) ⬆️
pkg/util/paramtable/component_param.go 98.18% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/param_item.go 89.18% <100.00%> (+0.19%) ⬆️
pkg/util/paramtable/role_param.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 90.22% <91.89%> (+0.02%) ⬆️
internal/distributed/proxy/service.go 81.72% <0.00%> (-0.66%) ⬇️
internal/proxy/impl.go 86.27% <14.28%> (-0.12%) ⬇️

... and 16 files with indirect coverage changes

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 4, 2023

/run-cpu-e2e

1 similar comment
@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 5, 2023

/run-cpu-e2e

@PowderLi PowderLi force-pushed the master-builtin-roles branch from 4f49161 to a2a6a2b Compare December 5, 2023 00:11
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 5, 2023

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Dec 5, 2023

/hold

Need to initialize roles and privileges through configuration.

@PowderLi PowderLi force-pushed the master-builtin-roles branch 2 times, most recently from 97afc7d to 5478157 Compare December 5, 2023 08:06
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi force-pushed the master-builtin-roles branch 2 times, most recently from 04ffd72 to e4cf8ea Compare December 5, 2023 09:41
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi PowderLi force-pushed the master-builtin-roles branch from e4cf8ea to 23a4e53 Compare December 6, 2023 02:38
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi mentioned this pull request Dec 6, 2023
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi PowderLi force-pushed the master-builtin-roles branch 2 times, most recently from 9ce4d59 to 2340075 Compare December 6, 2023 10:08
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 6, 2023

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

2 similar comments
@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 15, 2023
@PowderLi PowderLi force-pushed the master-builtin-roles branch from 1ee3543 to d0b6e6d Compare December 15, 2023 11:22
@mergify mergify bot removed the ci-passed label Dec 15, 2023
@PowderLi PowderLi force-pushed the master-builtin-roles branch from d0b6e6d to b9e30e6 Compare December 15, 2023 11:25
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@PowderLi
Copy link
Contributor Author

rerun ut

@PowderLi PowderLi force-pushed the master-builtin-roles branch 2 times, most recently from 9702763 to 7fe5d16 Compare December 16, 2023 15:38
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 16, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
enhance: support user-defined builtin roles
30d1127 
add new configuration: builtinRoles
upgrade proto to use partition related privileges

user can define roles in config file: milvus.yaml
there is an example:
1. db_ro, only have read privileges, include load
2. db_rw, read and write privileges, include create/drop/rename collection
3. db_admin, not only read and write privileges, but also user administration

Signed-off-by: PowderLi <[email protected]>
@PowderLi PowderLi force-pushed the master-builtin-roles branch from 7fe5d16 to 30d1127 Compare December 18, 2023 01:24
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 18, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 18, 2023
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 mentioned this pull request Dec 18, 2023
Merged
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2023

/unhold

@sre-ci-robot sre-ci-robot merged commit bcd6865 into milvus-io:master Dec 18, 2023
14 checks passed
@PowderLi PowderLi deleted the master-builtin-roles branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PowderLi @czs007 @sre-ci-robot