-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rootCoord decide the builtin role cannot be deleted #29248
Conversation
b8f5c98
to
327fc4d
Compare
@PowderLi Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
@PowderLi E2e jenkins job failed, comment |
327fc4d
to
abb00ec
Compare
@PowderLi E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #29248 +/- ##
==========================================
- Coverage 82.09% 82.08% -0.02%
==========================================
Files 832 832
Lines 119343 119344 +1
==========================================
- Hits 97971 97959 -12
- Misses 18149 18158 +9
- Partials 3223 3227 +4
|
abb00ec
to
aac9a01
Compare
@PowderLi E2e jenkins job failed, comment |
/run-cpu-e2e |
1 similar comment
/run-cpu-e2e |
only rootCoord read the configuration item `builtinRoles`, so proxy never know whether the role to be deleted is builtin. Signed-off-by: PowderLi <[email protected]>
aac9a01
to
ddf4c99
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, PowderLi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #29243
pr: #28961
only rootCoord read the configuration item
builtinRoles
, so proxy never know whether the role to be deleted is builtin.