Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rootCoord decide the builtin role cannot be deleted #29248

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 15, 2023

issue: #29243
pr: #28961
only rootCoord read the configuration item builtinRoles, so proxy never know whether the role to be deleted is builtin.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 15, 2023
@PowderLi PowderLi force-pushed the 2.3-builtin-roles-fix branch from b8f5c98 to 327fc4d Compare December 15, 2023 11:21
@mergify mergify bot added the dco-passed DCO check passed. label Dec 15, 2023
Copy link
Contributor

mergify bot commented Dec 15, 2023

@PowderLi Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 15, 2023
Copy link
Contributor

mergify bot commented Dec 15, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi force-pushed the 2.3-builtin-roles-fix branch from 327fc4d to abb00ec Compare December 15, 2023 11:30
Copy link
Contributor

mergify bot commented Dec 15, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #29248 (ddf4c99) into 2.3 (4ab02da) will decrease coverage by 0.02%.
Report is 1 commits behind head on 2.3.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29248      +/-   ##
==========================================
- Coverage   82.09%   82.08%   -0.02%     
==========================================
  Files         832      832              
  Lines      119343   119344       +1     
==========================================
- Hits        97971    97959      -12     
- Misses      18149    18158       +9     
- Partials     3223     3227       +4     
Files Coverage Δ
internal/proxy/impl.go 85.69% <100.00%> (ø)
internal/proxy/privilege_interceptor.go 76.72% <100.00%> (ø)
internal/proxy/util.go 91.34% <ø> (-0.07%) ⬇️
internal/rootcoord/root_coord.go 90.23% <100.00%> (+0.01%) ⬆️
pkg/util/constant.go 82.85% <100.00%> (+3.54%) ⬆️

... and 11 files with indirect coverage changes

@PowderLi PowderLi force-pushed the 2.3-builtin-roles-fix branch from abb00ec to aac9a01 Compare December 16, 2023 14:33
Copy link
Contributor

mergify bot commented Dec 16, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@PowderLi
Copy link
Contributor Author

/run-cpu-e2e

only rootCoord read the configuration item `builtinRoles`, so proxy never know whether the role to be deleted is builtin.

Signed-off-by: PowderLi <[email protected]>
@PowderLi PowderLi force-pushed the 2.3-builtin-roles-fix branch from aac9a01 to ddf4c99 Compare December 18, 2023 01:21
@mergify mergify bot added the ci-passed label Dec 18, 2023
@czs007
Copy link
Collaborator

czs007 commented Dec 18, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9af24da into milvus-io:2.3 Dec 18, 2023
14 checks passed
@PowderLi PowderLi deleted the 2.3-builtin-roles-fix branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants