Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rootCoord decide the builtin role cannot be deleted #29248

Merged
merged 1 commit into from
Dec 18, 2023

fix: rootCoord decide the builtin role cannot be deleted

ddf4c99
Select commit
Loading
Failed to load commit list.
Merged

fix: rootCoord decide the builtin role cannot be deleted #29248

fix: rootCoord decide the builtin role cannot be deleted
ddf4c99
Select commit
Loading
Failed to load commit list.
Mergify / Summary succeeded Dec 18, 2023 in 3s

5 rules match and 22 potential rules

⚠️ The pull request has been merged by @sre-ci-robot

Rule: Add needs-dco label when DCO check failed (label, comment)

  • -status-success=DCO
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

✅ Rule: Add dco-passed label when DCO check passed (label)

  • status-success=DCO
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

✅ Rule: Test passed for code changed-master (label)

  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker Amazonlinux 2023
  • status-success=Code Checker MacOS 12
  • status-success=codecov/patch
  • status-success=codecov/project
  • status-success=cpu-e2e
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
    • base=sql_beta

Rule: Test passed for tests changed (label)

  • -files~=^(?!tests\/python_client).+
  • status-success=cpu-e2e
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Test passed for docs changed only (label)

  • -files~=^(?!.*\.(md)).*$
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Test passed for non go or c++ code changed (label)

  • -files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt|conanfile\.*))).*$
  • status-success=cpu-e2e
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Test passed for go unittest code changed-master (label)

  • any of:
    • -files~=^(?!internal\/.*_test\.go).*$
    • -files~=^(?!pkg\/.*_test\.go).*$
  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker Amazonlinux 2023
  • status-success=Code Checker MacOS 12
  • status-success=UT for Go (20.04)
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
    • base=sql_beta

Rule: Test passed for mergify changed (label)

  • -files~=^(?!\.github\/mergify\.yml).*$
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Test passed for title skip e2e (label)

  • -files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt))).*$
  • label=kind/enhancement
  • title~=\[skip e2e\]
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Blocking PR if missing a related issue or doesn't have kind/enhancement label (label, comment)

  • all of:
    • -body~=\#[0-9]{1,6}(\s+|$)
    • -body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)
  • all of:
    • label=kind/enhancement
    • any of:
      • label=size/L
      • label=size/XL
      • label=size/XXL
  • -label=kind/doc
  • -label=kind/test
  • -title~=\[automated\]
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

✅ Rule: Dismiss block label if related issue be added into PR (label)

  • any of:
    • all of:
      • any of:
        • base~=^2(\.\d+){1,2}$
        • base=master
        • base=sql_beta
      • any of:
        • body~=\#[0-9]{1,6}(\s+|$)
        • body~=https://github.com/milvus-io/milvus/issues/[0-9]{1,6}(\s+|$)
    • all of:
      • all of:
        • label=kind/enhancement
        • -label=size/L
        • -label=size/XL
        • -label=size/XXL
      • any of:
        • base~=^2(\.\d+){1,2}$
        • base=master
        • base=sql_beta

Rule: Blocking PR if missing a related master PR or doesn't have kind/branch-feature label (label, comment)

  • all of:
    • -body~=pr\:\ \#[0-9]{1,6}(\s+|$)
    • -body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
  • -label=kind/branch-feature
  • -title~=\[automated\]
  • base~=^2(\.\d+){1,2}$

✅ Rule: Dismiss block label if related pr be added into PR (label)

  • base~=^2(\.\d+){1,2}$
  • any of:
    • body~=pr\:\ \#[0-9]{1,6}(\s+|$)
    • body~=https://github.com/milvus-io/milvus/pull/[0-9]{1,6}(\s+|$)
    • label=kind/branch-feature

Rule: Dismiss block label if automated create PR (label)

  • title~=\[automated\]
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Test passed for skip e2e-master (label)

  • title~=\[skip e2e\]
  • files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt))).*$
  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker Amazonlinux 2023
  • status-success=Code Checker MacOS 12
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
    • base=sql_beta

Rule: Assign the 'lgtm' and 'approved' labels following the successful testing of the 'Update Knowhere Commit' (label)

  • title~=Update Knowhere Commit
  • label=ci-passed
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Remove ci-passed label when status for code checker or ut is not success-master (label)

  • any of:
    • status-success!=Build and test AMD64 Ubuntu 20.04
    • status-success!=Code Checker AMD64 Ubuntu 20.04
    • status-success!=Code Checker Amazonlinux 2023
    • status-success!=Code Checker MacOS 12
  • files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt))).*$
  • label!=manual-pass
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
    • base=sql_beta

Rule: Remove ci-passed label when status for jenkins job is not success (label)

  • status-success!=cpu-e2e
  • -title~=\[skip e2e\]
  • files~=^(?!(.*_test\.go|.*\.md)).*$
  • label!=manual-pass
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Add comment when jenkins job failed (comment)

  • check-failure=cpu-e2e
  • any of:
    • base~=^2(\.\d+){1,2}$
    • base=master
    • base=sql_beta

Rule: Add comment when code checker or ut failed -master (comment)

  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Code Checker AMD64 Ubuntu 20.04
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
    • base=sql_beta

Rule: Add 'do-not-merge/invalid-pr-format' label for invalid PR titles (label, comment)

  • any of:
    • -title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
    • body=^$
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

Rule: Remove 'do-not-merge/invalid-pr-format' label for valid PRs (label)

  • label=do-not-merge/invalid-pr-format
  • -body=^$
  • title~=^(feat:|enhance:|fix:|test:|doc:|auto:|\[automated\])
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

✅ Rule: Label bug fix PRs (label)

  • title~=^fix:
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

Rule: Label feature PRs (label)

  • title~=^feat:
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

Rule: Label enhancement PRs (label)

  • title~=^enhance:
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

Rule: Label test PRs (label)

  • title~=^test:
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master

Rule: Label doc PRs (label)

  • title~=^doc:
  • any of:
    • base~=^2\.3(\.\d+){0,1}$
    • base=master
💖  Mergify is proud to provide this service for free to open source projects.

🚀  You can help us by becoming a sponsor!

5 not applicable rules

Rule: Test passed for code changed -2.2.* (label)

  • base~=^2(\.\d+){2}$
  • status-success=Code Checker CentOS 7
  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker MacOS 12
  • status-success=codecov/patch
  • status-success=codecov/project
  • status-success=cpu-e2e

Rule: Test passed for go unittest code changed -2.2.* (label)

  • -files~=^(?!internal\/.*_test\.go).*$
  • base~=^2\.2\.\d+$
  • status-success=Code Checker CentOS 7
  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker MacOS 12

Rule: Test passed for skip e2e - 2.2.* (label)

  • base~=^2\.2\.\d+$
  • status-success=Code Checker CentOS 7
  • title~=\[skip e2e\]
  • files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt))).*$
  • status-success=Build and test AMD64 Ubuntu 20.04
  • status-success=Code Checker AMD64 Ubuntu 20.04
  • status-success=Code Checker MacOS 12

Rule: Remove ci-passed label when status for code checker or ut is not success-2.2.* (label)

  • base~=^2\.2\.\d+$
  • files~=^(?=.*((\.(go|h|cpp)|CMakeLists.txt))).*$
  • label!=manual-pass
  • any of:
    • status-success!=Code Checker CentOS 7
    • status-success!=Build and test AMD64 Ubuntu 20.04
    • status-success!=Code Checker AMD64 Ubuntu 20.04
    • status-success!=Code Checker MacOS 12

Rule: Add comment when code checker or ut failed -2.2.* (comment)

  • base~=^2\.2\.\d+$
  • any of:
    • check-failure=Build and test AMD64 Ubuntu 20.04
    • check-failure=Code Checker AMD64 Ubuntu 20.04
Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

View more details on Mergify