Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: add 3 builtin roles #28961 #29010

Merged
merged 1 commit into from
Dec 8, 2023
Merged

enhance: add 3 builtin roles #28961 #29010

merged 1 commit into from
Dec 8, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Dec 6, 2023

issue: #28960
master pr: #28961

add new configuration: builtinRoles
user can define roles in config file: milvus.yaml

there is an example:

db_ro, only have read privileges, include load
db_rw, read and write privileges, include create/drop/rename collection
db_admin, not only read and write privileges, but also user administration

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 6, 2023
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 6, 2023

rerun ut

@czs007 czs007 added this to the 2.3.4 milestone Dec 6, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 6, 2023

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Merging #29010 (6243d07) into 2.3 (5f4ac43) will decrease coverage by 0.02%.
Report is 4 commits behind head on 2.3.
The diff coverage is 96.87%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #29010      +/-   ##
==========================================
- Coverage   82.02%   82.00%   -0.02%     
==========================================
  Files         831      832       +1     
  Lines      118941   119036      +95     
==========================================
+ Hits        97557    97618      +61     
- Misses      18158    18184      +26     
- Partials     3226     3234       +8
Files Coverage Δ
internal/proxy/impl.go 85.80% <100.00%> (ø)
internal/proxy/util.go 91.41% <100.00%> (+0.06%) ⬆️
pkg/util/constant.go 79.31% <ø> (ø)
pkg/util/funcutil/func.go 88.49% <100.00%> (+1.15%) ⬆️
pkg/util/paramtable/component_param.go 98.19% <100.00%> (+<0.01%) ⬆️
pkg/util/paramtable/param_item.go 89.18% <100.00%> (+0.19%) ⬆️
pkg/util/paramtable/role_param.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 90.00% <90.90%> (+0.01%) ⬆️

... and 12 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 6, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 7, 2023

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi PowderLi force-pushed the 2.3-builtin-roles branch 2 times, most recently from 10df741 to a7256a9 Compare December 7, 2023 06:59
@PowderLi
enhance: support user-defined builtin roles
6243d07 
add new configuration: builtinRoles
user can define roles in config file: milvus.yaml

there is an example:
1. db_ro, only have read privileges, include load
2. db_rw, read and write privileges, include create/drop/rename collection
3. db_admin, not only read and write privileges, but also user administration

Signed-off-by: PowderLi <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 7, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 7, 2023

/run-cpu-e2e

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 7, 2023

rerun ut

@PowderLi
Copy link
Contributor Author

PowderLi commented Dec 7, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 8, 2023
@czs007
Copy link
Collaborator

czs007 commented Dec 8, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 10d3224 into milvus-io:2.3 Dec 8, 2023
14 checks passed
@PowderLi PowderLi deleted the 2.3-builtin-roles branch January 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@PowderLi @czs007 @sre-ci-robot