Remove return type for make() #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove static return type. See lorisleiva#285 (comment)
|
Thank you! 🍺 Two small things before merging:
|
|
Done! |
|
Thanks! |
|
This has broken IDE autocompletion for me. Now PhpStorm thinks I deliberately don't use the |
|
@austincarpenter Hi there, this was a partial revert of #285 which was only published a |
|
@lorisleiva Prior to #285 it was working due to the docblock, also after due to the return type and now post #287 it's not due to neither a docblock nor a return type. |
|
Gotcha, so we just need the docblock back right? If so, would you be able to submit a small PR for this and I'll get that merged/patched immediately? |
TaylorWilton
pushed a commit
to TaylorWilton/laravel-actions
that referenced
this pull request
Sep 9, 2024
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing garbage autocomplete. The solution is to instead add back a phpdoc comment for this specific use case. See lorisleiva#285 and lorisleiva#287 for more details.
TaylorWilton
pushed a commit
to TaylorWilton/laravel-actions
that referenced
this pull request
Sep 9, 2024
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing incorrect autocomplete information. The solution is to instead add back a phpdoc comment for this specific use case. See lorisleiva#285 and lorisleiva#287 for more details.
TaylorWilton
pushed a commit
to TaylorWilton/laravel-actions
that referenced
this pull request
Sep 9, 2024
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing incorrect autocomplete information. The solution is to instead add back a phpdoc comment for this specific use case. See lorisleiva#285 and lorisleiva#287 for more details.
TaylorWilton
added a commit
to TaylorWilton/laravel-actions
that referenced
this pull request
Sep 9, 2024
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing incorrect autocomplete information. The solution is to instead add back a phpdoc comment for this specific use case. See lorisleiva#285 and lorisleiva#287 for more details.
lorisleiva
pushed a commit
that referenced
this pull request
Sep 10, 2024
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing incorrect autocomplete information. The solution is to instead add back a phpdoc comment for this specific use case. See #285 and #287 for more details.
|
Apologies for the delay on this one. Thanks @TaylorWilton @lorisleiva 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove static return type. See #285 (comment)