Remove return type for make() (#287)

lorisleiva · Aug 20, 2024 · e55c1ea · e55c1ea
1 parent 4f4847e
commit e55c1ea
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Concerns/AsObject.php b/src/Concerns/AsObject.php
@@ -6,7 +6,7 @@
 
 trait AsObject
 {
-    public static function make(): static
+    public static function make()
     {
         return app(static::class);
     }

diff --git a/tests/AsActionTest.php b/tests/AsActionTest.php
@@ -85,6 +85,13 @@ public function asCommand(Command $command): void
     expect(AsActionTest::$latestResult)->toBe(42);
 });
 
+it('returns void when calling make()', function () {
+    // Make sure that the static function ::make() returns not a type.
+    $result = (new \ReflectionMethod(AsActionTest::class, 'make'))->getReturnType();
+
+    expect($result)->toBeEmpty();
+});
+
 it('runs as a controller', function () {
     // Given we have a route registered for that action.
     Route::post('compute/{operation}', AsActionTest::class);