Add a Return Type using PHPDoc to fix IDE Autocomplete #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TaylorWilton
force-pushed
the
feature/fix-as-object-dockblock
branch
from
d381b22 to
96247db
Compare
The make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing incorrect autocomplete information. The solution is to instead add back a phpdoc comment for this specific use case. See lorisleiva#285 and lorisleiva#287 for more details.
TaylorWilton
force-pushed
the
feature/fix-as-object-dockblock
branch
from
96247db to
794d8e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I've also been affected by the IDE autocompletion issue noted in #285 and #287.
I figured since it was a simple PR and no-one else had done it yet I may as well create it.
My understanding of the issue is that the make function can't define a return type, because the result could be a Decorator, or the actual action. However, without docblocks or type-hinting, PHPStorm ends up providing the autocompletion for the
handlefunction defined in the application container, which is different.I've returned the docblock here, which resolves the issue for me locally, and won't cause any type errors.
Thanks for your work maintaining this package!
(e: sorry for the force push mixup - on a work laptop and had to change git accounts 😅 )