-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/4249/brand audit #4343
Chore/4249/brand audit #4343
Conversation
9c0b4d7
to
bce857c
Compare
@@ -17,6 +17,9 @@ export function ControlledDrawer(props: ControlledDrawerProps) { | |||
|
|||
return ( | |||
<BaseDrawer | |||
height="100vh" | |||
position={['absolute', 'fixed']} | |||
top={['-24px', 0]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a screenshot of what you are fixing here? I'm a bit lost on why I'm not seeing anything broken on my branch with the BaseDrawer
. 🤔 Maybe I'm just not understanding the change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I put some screenshots and more explanation in the ticket linked with this commit:
#4165 (comment)
I'm doing this to close the gap between the top of the modal and the top of the extension:
Kapture.2023-10-12.at.08.46.08.mp4
If you see that comment, it seems like most of the modals we use have this gap in extension mode.
Kapture.2023-10-12.at.08.48.43.mp4
I have this task to add containers - #4165 but on review of that I'm not sure if that will solve this.
We have issues in extension mode with how we display our modals. If that containers task is to fix the issue we will be changing most modals into full page views which I'm not sure we want to do.
CC @kyranjamie - maybe we need to catch up on this?
src/app/features/switch-account-drawer/components/create-account-action.tsx
Outdated
Show resolved
Hide resolved
4ad6d06
to
65a0076
Compare
@pete-watters shall we revert the hard angles to the rounded corners and deal with this is separated ticket? |
I didn't change those. Are we going to remove all rounded corners? I can just do that first if you want and get it merged. Then we don't have to add them and remove them again |
This PR fixes some issues flagged in the: