Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/4249/brand audit #4343

Merged
merged 9 commits into from
Oct 13, 2023
Merged

Chore/4249/brand audit #4343

merged 9 commits into from
Oct 13, 2023

Conversation

@pete-watters pete-watters self-assigned this Oct 11, 2023
@pete-watters pete-watters force-pushed the chore/4249/brand-audit branch 2 times, most recently from 9c0b4d7 to bce857c Compare October 11, 2023 11:46
@pete-watters pete-watters linked an issue Oct 11, 2023 that may be closed by this pull request
@pete-watters pete-watters marked this pull request as ready for review October 11, 2023 13:57
@pete-watters pete-watters linked an issue Oct 11, 2023 that may be closed by this pull request
@@ -17,6 +17,9 @@ export function ControlledDrawer(props: ControlledDrawerProps) {

return (
<BaseDrawer
height="100vh"
position={['absolute', 'fixed']}
top={['-24px', 0]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a screenshot of what you are fixing here? I'm a bit lost on why I'm not seeing anything broken on my branch with the BaseDrawer. 🤔 Maybe I'm just not understanding the change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put some screenshots and more explanation in the ticket linked with this commit:
#4165 (comment)

I'm doing this to close the gap between the top of the modal and the top of the extension:

Kapture.2023-10-12.at.08.46.08.mp4

If you see that comment, it seems like most of the modals we use have this gap in extension mode.

Kapture.2023-10-12.at.08.48.43.mp4

I have this task to add containers - #4165 but on review of that I'm not sure if that will solve this.

We have issues in extension mode with how we display our modals. If that containers task is to fix the issue we will be changing most modals into full page views which I'm not sure we want to do.

CC @kyranjamie - maybe we need to catch up on this?

@pete-watters pete-watters linked an issue Oct 12, 2023 that may be closed by this pull request
@pete-watters pete-watters force-pushed the chore/4249/brand-audit branch from 4ad6d06 to 65a0076 Compare October 13, 2023 11:42
@pete-watters pete-watters added this pull request to the merge queue Oct 13, 2023
Merged via the queue into dev with commit 230fe46 Oct 13, 2023
25 checks passed
@pete-watters pete-watters deleted the chore/4249/brand-audit branch October 13, 2023 11:44
@mica000
Copy link

mica000 commented Oct 16, 2023

@pete-watters shall we revert the hard angles to the rounded corners and deal with this is separated ticket? Screenshot 2023-10-16 at 13 03 09

@pete-watters
Copy link
Contributor Author

@pete-watters shall we revert the hard angles to the rounded corners and deal with this is separated ticket? Screenshot 2023-10-16 at 13 03 09

I didn't change those. Are we going to remove all rounded corners? I can just do that first if you want and get it merged. Then we don't have to add them and remove them again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix refresh icon alignment for collectibles chore: brand audit changes Design System - Add containers
4 participants