Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix refresh icon alignment for collectibles #4290

Closed
markmhendrickson opened this issue Sep 29, 2023 · 2 comments · Fixed by #4343 or #4356
Closed

Fix refresh icon alignment for collectibles #4290

markmhendrickson opened this issue Sep 29, 2023 · 2 comments · Fixed by #4343 or #4356
Assignees
@pete-watters

Comments

@markmhendrickson
Copy link
Collaborator

Image
@mica000
Copy link

mica000 commented Oct 10, 2023

this can be done in the Brand audit ticket pherhaps, since it will also update the font size?
https://github.com/orgs/leather-wallet/projects/1/views/1?pane=issue&itemId=39370740

@pete-watters
Copy link
Contributor

Yes I can fix that in issue #4249 .

@mica000 I was changing the font there to be label.01 but it still looks wrong compared to the design.

In our system label.01 is using 'Diatype' but in the brand audit file it's Inter.

Does it look OK here using label.01 ?

Screenshot 2023-10-11 at 08 56 49

pete-watters added a commit that referenced this issue Oct 11, 2023
@pete-watters
fix: update collectible header font and align icon, closes #4290
ea4fd8a
@pete-watters pete-watters mentioned this issue Oct 11, 2023
Merged
@pete-watters pete-watters linked a pull request Oct 11, 2023 that will close this issue
Chore/4249/brand audit #4343
Merged
pete-watters added a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: update collectible header font and align icon, closes #4290
e89775b
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: update collectible header font and align icon, closes #4290
e88a18b
@fbwoolf fbwoolf mentioned this issue Oct 13, 2023
Merged
kyranjamie pushed a commit that referenced this issue Oct 13, 2023
@semantic-release-bot
chore(release): 6.11.0
2b7b556 
## [6.11.0](v6.10.0...v6.11.0) (2023-10-13)

### Features

* sBTC devenv network ([1eb34b8](1eb34b8))

### Bug Fixes

* alter position of receive modal in extension view,  [#4165](#4165) ([07989ae](07989ae))
* change tab hover bg colour, closes [#4249](#4249) ([1f8e863](1f8e863))
* give activity screen a min height to stop it jumping when empty, closes [#4249](#4249) ([75466bd](75466bd))
* improve display of select account in extension mode, [#4165](#4165) ([f09aec3](f09aec3))
* make adjustments based on PR review feedback ([29c5d59](29c5d59))
* name wrapper more specifically ([230fe46](230fe46))
* properly switch between 12 and 24 word inputs, closes [#4250](#4250) ([1a86b85](1a86b85))
* stop create account button disappearing at smaller heights, [#4165](#4165) ([f166a31](f166a31))
* update address displayer to use text-subdued for odd, closes [#4249](#4249) ([a9562c6](a9562c6))
* update collectible header font and align icon, closes [#4290](#4290) ([e88a18b](e88a18b))

### Internal

* fix missing protocol ([ba1a712](ba1a712))
@pete-watters pete-watters linked a pull request Oct 16, 2023 that will close this issue
release: brand audit #4356
Merged
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: update collectible header font and align icon, closes leather-io…
c6f9217 
…#4290
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.11.0
7ec9a7a 
## [6.11.0](leather-io/extension@v6.10.0...v6.11.0) (2023-10-13)

### Features

* sBTC devenv network ([1eb34b8](leather-io@1eb34b8))

### Bug Fixes

* alter position of receive modal in extension view,  [leather-io#4165](leather-io#4165) ([07989ae](leather-io@07989ae))
* change tab hover bg colour, closes [leather-io#4249](leather-io#4249) ([1f8e863](leather-io@1f8e863))
* give activity screen a min height to stop it jumping when empty, closes [leather-io#4249](leather-io#4249) ([75466bd](leather-io@75466bd))
* improve display of select account in extension mode, [leather-io#4165](leather-io#4165) ([f09aec3](leather-io@f09aec3))
* make adjustments based on PR review feedback ([29c5d59](leather-io@29c5d59))
* name wrapper more specifically ([230fe46](leather-io@230fe46))
* properly switch between 12 and 24 word inputs, closes [leather-io#4250](leather-io#4250) ([1a86b85](leather-io@1a86b85))
* stop create account button disappearing at smaller heights, [leather-io#4165](leather-io#4165) ([f166a31](leather-io@f166a31))
* update address displayer to use text-subdued for odd, closes [leather-io#4249](leather-io#4249) ([a9562c6](leather-io@a9562c6))
* update collectible header font and align icon, closes [leather-io#4290](leather-io#4290) ([e88a18b](leather-io@e88a18b))

### Internal

* fix missing protocol ([ba1a712](leather-io@ba1a712))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore/4249/brand audit leather-io/extension
release: brand audit leather-io/extension
3 participants
@markmhendrickson @pete-watters @mica000