Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: brand audit changes #4249

Closed
pete-watters opened this issue Sep 21, 2023 · 1 comment · Fixed by #4343, #4356 or #4372
Closed

chore: brand audit changes #4249

pete-watters opened this issue Sep 21, 2023 · 1 comment · Fixed by #4343, #4356 or #4372
Assignees
@pete-watters
Labels
area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives

Comments

@pete-watters
Copy link
Contributor

pete-watters commented Sep 21, 2023 •
edited
Loading

We went through the brand audit today and there are some things to fix. We decided to fix some small things soon but tackle the others when re-working the UI foundation.

Quick fixes for now:

  • Change font of collectibles header to label 1
  • Change tab hover BG color to component-bg-hover
  • Set minimum height of main container in Assets / activity to be the same based on the height of our empty assets screen
  • Change text colour of BTC address secondary to subdued
  • Fix colors in Send screen empty 0 and Enter recipient address

Brand Audit:
https://www.figma.com/file/GU3X88E6UJWA3JtbP7FThe/%F0%9F%94%AC-Brand-v0-Audit?type=design&node-id=1%3A125&mode=design&t=h0oX07Q0cFocF07j-1

CC @mica000 @markmhendrickson @fabric-8
@pete-watters pete-watters self-assigned this Sep 21, 2023
@pete-watters pete-watters mentioned this issue Sep 21, 2023
Closed
@markmhendrickson markmhendrickson added Enhancement 💡 enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives labels Sep 26, 2023
@mica000 mica000 added the area:ui UI engineering specific tasks. label Oct 3, 2023
@pete-watters pete-watters mentioned this issue Oct 11, 2023
Closed
pete-watters added a commit that referenced this issue Oct 11, 2023
@pete-watters
fix: update address displayer to use text-subdued for odd, closes #4249
02d035b
pete-watters added a commit that referenced this issue Oct 11, 2023
@pete-watters
fix: change tab hover bg colour, closes #4249
3b4bdc4
pete-watters added a commit that referenced this issue Oct 11, 2023
@pete-watters
fix: give activity screen a min height to stop it jumping when empty, c…
9036f3b 
…loses #4249
@pete-watters pete-watters linked a pull request Oct 11, 2023 that will close this issue
Chore/4249/brand audit #4343
Merged
@pete-watters pete-watters mentioned this issue Oct 11, 2023
Merged
@pete-watters
Copy link
Contributor Author

pete-watters commented Oct 11, 2023 •
edited
Loading

I fixed all of these issues apart from 'Fix colors in Send screen empty 0 and Enter recipient address'

I opened a new ticket for that here: #4345

CC @markmhendrickson @mica000 @fabric-8

@pete-watters pete-watters mentioned this issue Oct 11, 2023
Closed
pete-watters added a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: update address displayer to use text-subdued for odd, closes #4249
14d9ff9
pete-watters added a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: change tab hover bg colour, closes #4249
0c7c4c2
pete-watters added a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: give activity screen a min height to stop it jumping when empty, c…
4c23432 
…loses #4249
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: update address displayer to use text-subdued for odd, closes #4249
a9562c6
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: change tab hover bg colour, closes #4249
1f8e863
github-merge-queue bot pushed a commit that referenced this issue Oct 13, 2023
@pete-watters
fix: give activity screen a min height to stop it jumping when empty, c…
75466bd 
…loses #4249
@fbwoolf fbwoolf mentioned this issue Oct 13, 2023
Merged
kyranjamie pushed a commit that referenced this issue Oct 13, 2023
@semantic-release-bot
chore(release): 6.11.0
2b7b556 
## [6.11.0](v6.10.0...v6.11.0) (2023-10-13)

### Features

* sBTC devenv network ([1eb34b8](1eb34b8))

### Bug Fixes

* alter position of receive modal in extension view,  [#4165](#4165) ([07989ae](07989ae))
* change tab hover bg colour, closes [#4249](#4249) ([1f8e863](1f8e863))
* give activity screen a min height to stop it jumping when empty, closes [#4249](#4249) ([75466bd](75466bd))
* improve display of select account in extension mode, [#4165](#4165) ([f09aec3](f09aec3))
* make adjustments based on PR review feedback ([29c5d59](29c5d59))
* name wrapper more specifically ([230fe46](230fe46))
* properly switch between 12 and 24 word inputs, closes [#4250](#4250) ([1a86b85](1a86b85))
* stop create account button disappearing at smaller heights, [#4165](#4165) ([f166a31](f166a31))
* update address displayer to use text-subdued for odd, closes [#4249](#4249) ([a9562c6](a9562c6))
* update collectible header font and align icon, closes [#4290](#4290) ([e88a18b](e88a18b))

### Internal

* fix missing protocol ([ba1a712](ba1a712))
@pete-watters pete-watters linked a pull request Oct 16, 2023 that will close this issue
release: brand audit #4356
Merged
pete-watters added a commit that referenced this issue Oct 18, 2023
@pete-watters
fix: revert drawer changes from brand audit, closes #4249
3192aae
@pete-watters pete-watters linked a pull request Oct 18, 2023 that will close this issue
fix: revert drawer changes from brand audit, closes #4249 #4372
Merged
pete-watters added a commit that referenced this issue Oct 18, 2023
@pete-watters
fix: revert drawer changes from brand audit, closes #4249
2ed6b6d
github-merge-queue bot pushed a commit that referenced this issue Oct 18, 2023
@pete-watters
fix: revert drawer changes from brand audit, closes #4249
e437710
kyranjamie pushed a commit that referenced this issue Oct 24, 2023
@semantic-release-bot
chore(release): 6.12.0
a05052f 
## [6.12.0](v6.11.0...v6.12.0) (2023-10-24)

### Features

* add connect btn ([3903ba1](3903ba1))
* add unsupported browsers modal ([2febd49](2febd49))
* added bitcoin contract list page and entry point ([a28678d](a28678d))
* added tests for bitcoin contract request ([157f97e](157f97e))
* return addresses of regtest and signet ([a0717e3](a0717e3))
* rework onboarding ledger flow, closes [#4281](#4281) ([47aa2e2](47aa2e2))

### Bug Fixes

* align text and caption left so it appears correctly in extension view ([bd25751](bd25751))
* allow direct access to /receive/stx ([e7c8d8d](e7c8d8d))
* change acc bug ([ce13789](ce13789))
* clean code ([77a4822](77a4822))
* clean code, add note re ordinals modal ([a06aa39](a06aa39))
* clean code, add note re ordinals modal ([993df34](993df34))
* close original recieve modal before opening qr code modal to prevent double modal ([10b7246](10b7246))
* code spanning past viewport width ([db35a49](db35a49))
* do not nest recieve sub routes to prevent double overlay of modal and maintain direct access ([1477c96](1477c96))
* enable bg redirect to overlay modal in new tab ([36c969f](36c969f))
* get build passing ([5826143](5826143))
* improve type loading ([d79ee62](d79ee62))
* ledger tx sign error process ([618923f](618923f))
* pass child routes as children to appease dep cruiser ([200907a](200907a))
* re-introduce bg location for hometabs so modals overlay on top of activity ([12571b0](12571b0))
* refactor modals to overlay on top of backgroundLocation consistently, closes [#4028](#4028) ([c006894](c006894))
* revert drawer changes from brand audit, closes [#4249](#4249) ([e437710](e437710))
* update path to receive stx to fix test ([2c897ab](2c897ab))
* use bg location to open in new tab. share modal bg logic ([07c5c98](07c5c98))
* use grid for asset rows to stop overflow while allowing width, closes [#4171](#4171) ([529c03d](529c03d))
* use independant route for FundReceiveStx ([e4bfd24](e4bfd24))
* use network.chain.bitcoin.url in api hooks, closes [#4330](#4330) ([ceaf228](ceaf228))
* wallet type definition ([ddc91e3](ddc91e3))
* welcome page header padding, closes [#4374](#4374) ([0817a5e](0817a5e))

### Internal

* debug window close util ([77056e7](77056e7))
* deprecate unused routes ([a3710c5](a3710c5))
* explore routing issues ([0dbbdcf](0dbbdcf))
* local copyToClipboard hook ([017fa3a](017fa3a))
* psbt stackui layout ([e71e457](e71e457))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: update address displayer to use text-subdued for odd, closes lea…
c5c6110 
…ther-io#4249
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: change tab hover bg colour, closes leather-io#4249
c01bf65
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: give activity screen a min height to stop it jumping when empty, c…
95c4bd5 
…loses leather-io#4249
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.11.0
7ec9a7a 
## [6.11.0](leather-io/extension@v6.10.0...v6.11.0) (2023-10-13)

### Features

* sBTC devenv network ([1eb34b8](leather-io@1eb34b8))

### Bug Fixes

* alter position of receive modal in extension view,  [leather-io#4165](leather-io#4165) ([07989ae](leather-io@07989ae))
* change tab hover bg colour, closes [leather-io#4249](leather-io#4249) ([1f8e863](leather-io@1f8e863))
* give activity screen a min height to stop it jumping when empty, closes [leather-io#4249](leather-io#4249) ([75466bd](leather-io@75466bd))
* improve display of select account in extension mode, [leather-io#4165](leather-io#4165) ([f09aec3](leather-io@f09aec3))
* make adjustments based on PR review feedback ([29c5d59](leather-io@29c5d59))
* name wrapper more specifically ([230fe46](leather-io@230fe46))
* properly switch between 12 and 24 word inputs, closes [leather-io#4250](leather-io#4250) ([1a86b85](leather-io@1a86b85))
* stop create account button disappearing at smaller heights, [leather-io#4165](leather-io#4165) ([f166a31](leather-io@f166a31))
* update address displayer to use text-subdued for odd, closes [leather-io#4249](leather-io#4249) ([a9562c6](leather-io@a9562c6))
* update collectible header font and align icon, closes [leather-io#4290](leather-io#4290) ([e88a18b](leather-io@e88a18b))

### Internal

* fix missing protocol ([ba1a712](leather-io@ba1a712))
pete-watters added a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@pete-watters
fix: revert drawer changes from brand audit, closes leather-io#4249
27631f3
pete-watters pushed a commit to Nithishvb/extension that referenced this issue Jan 17, 2024
@semantic-release-bot @pete-watters
chore(release): 6.12.0
862bf70 
## [6.12.0](leather-io/extension@v6.11.0...v6.12.0) (2023-10-24)

### Features

* add connect btn ([3903ba1](leather-io@3903ba1))
* add unsupported browsers modal ([2febd49](leather-io@2febd49))
* added bitcoin contract list page and entry point ([a28678d](leather-io@a28678d))
* added tests for bitcoin contract request ([157f97e](leather-io@157f97e))
* return addresses of regtest and signet ([a0717e3](leather-io@a0717e3))
* rework onboarding ledger flow, closes [leather-io#4281](leather-io#4281) ([47aa2e2](leather-io@47aa2e2))

### Bug Fixes

* align text and caption left so it appears correctly in extension view ([bd25751](leather-io@bd25751))
* allow direct access to /receive/stx ([e7c8d8d](leather-io@e7c8d8d))
* change acc bug ([ce13789](leather-io@ce13789))
* clean code ([77a4822](leather-io@77a4822))
* clean code, add note re ordinals modal ([a06aa39](leather-io@a06aa39))
* clean code, add note re ordinals modal ([993df34](leather-io@993df34))
* close original recieve modal before opening qr code modal to prevent double modal ([10b7246](leather-io@10b7246))
* code spanning past viewport width ([db35a49](leather-io@db35a49))
* do not nest recieve sub routes to prevent double overlay of modal and maintain direct access ([1477c96](leather-io@1477c96))
* enable bg redirect to overlay modal in new tab ([36c969f](leather-io@36c969f))
* get build passing ([5826143](leather-io@5826143))
* improve type loading ([d79ee62](leather-io@d79ee62))
* ledger tx sign error process ([618923f](leather-io@618923f))
* pass child routes as children to appease dep cruiser ([200907a](leather-io@200907a))
* re-introduce bg location for hometabs so modals overlay on top of activity ([12571b0](leather-io@12571b0))
* refactor modals to overlay on top of backgroundLocation consistently, closes [leather-io#4028](leather-io#4028) ([c006894](leather-io@c006894))
* revert drawer changes from brand audit, closes [leather-io#4249](leather-io#4249) ([e437710](leather-io@e437710))
* update path to receive stx to fix test ([2c897ab](leather-io@2c897ab))
* use bg location to open in new tab. share modal bg logic ([07c5c98](leather-io@07c5c98))
* use grid for asset rows to stop overflow while allowing width, closes [leather-io#4171](leather-io#4171) ([529c03d](leather-io@529c03d))
* use independant route for FundReceiveStx ([e4bfd24](leather-io@e4bfd24))
* use network.chain.bitcoin.url in api hooks, closes [leather-io#4330](leather-io#4330) ([ceaf228](leather-io@ceaf228))
* wallet type definition ([ddc91e3](leather-io@ddc91e3))
* welcome page header padding, closes [leather-io#4374](leather-io#4374) ([0817a5e](leather-io@0817a5e))

### Internal

* debug window close util ([77056e7](leather-io@77056e7))
* deprecate unused routes ([a3710c5](leather-io@a3710c5))
* explore routing issues ([0dbbdcf](leather-io@0dbbdcf))
* local copyToClipboard hook ([017fa3a](leather-io@017fa3a))
* psbt stackui layout ([e71e457](leather-io@e71e457))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pete-watters pete-watters

Labels
area:ui UI engineering specific tasks. enhancement-p3 Non-critical functionality wanted by many users, or there are clear alternatives
Projects
None yet
Milestone
No milestone
3 participants
@markmhendrickson @pete-watters @mica000