Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: psbt bare utxo signing #4060

Merged
merged 1 commit into from
Nov 21, 2023
Merged

fix: psbt bare utxo signing #4060

merged 1 commit into from
Nov 21, 2023

Conversation

fbwoolf
Copy link
Contributor

@fbwoolf fbwoolf commented Jul 25, 2023

Try out this version of Leather — download extension builds.

Solution to handle bare UTXO signing.

The app has to initialize the tx with disableScriptCheck: true, and the changes here would handle getting the address from script type 'ms' w/out errors.

Todo:

  • Put up issue in btc-signer lib to handle all types there.

EDIT: Issue opened here: paulmillr/scure-btc-signer#55

@markmhendrickson markmhendrickson linked an issue Jul 26, 2023 that may be closed by this pull request
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from fc26bc7 to 3ae0dc4 Compare July 27, 2023 15:09
@fbwoolf fbwoolf requested a review from kyranjamie July 27, 2023 15:11
@vercel vercel bot temporarily deployed to Preview July 27, 2023 15:12 Inactive
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from 3ae0dc4 to d89e02e Compare July 27, 2023 15:20
@vercel vercel bot temporarily deployed to Preview July 27, 2023 15:20 Inactive
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from d89e02e to df2fd08 Compare July 27, 2023 16:56
@vercel vercel bot temporarily deployed to Preview July 27, 2023 16:56 Inactive
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from df2fd08 to 7dd976c Compare July 31, 2023 16:23
@vercel vercel bot temporarily deployed to Preview July 31, 2023 16:25 Inactive
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from 7dd976c to ec7ae7b Compare July 31, 2023 17:07
@vercel vercel bot temporarily deployed to Preview July 31, 2023 17:07 Inactive
@fbwoolf fbwoolf marked this pull request as ready for review July 31, 2023 17:23
@fbwoolf fbwoolf changed the title [WIP] fix: psbt bare utxo signing fix: psbt bare utxo signing Jul 31, 2023
@fbwoolf fbwoolf requested a review from pete-watters July 31, 2023 17:52
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from ec7ae7b to cc1881e Compare July 31, 2023 17:53
@vercel vercel bot temporarily deployed to Preview July 31, 2023 17:54 Inactive
@fbwoolf
Copy link
Contributor Author

fbwoolf commented Jul 31, 2023

@kyranjamie what do you think about this response?
paulmillr/scure-btc-signer#55

@kyranjamie
Copy link
Collaborator

Where does ms come from in the first place @fbwoolf ?

@fbwoolf
Copy link
Contributor Author

fbwoolf commented Aug 1, 2023

Where does ms come from in the first place @fbwoolf ?

ms is the outscript type supplied by the app trying to do multisig. Apparently, though, they are doing it wrong, see this comment on issue: #3897 (comment)

EDIT: It appears I need to refactor this and NOT handle ms this way. The lib has chosen not to handle it for a reason. Link to comment on issue with example script: #3897 (comment) It does seem like this PR fixes the issue for those using bitcoinjs, so I think we should merge it?

@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from cc1881e to 3053545 Compare August 3, 2023 17:35
@vercel vercel bot temporarily deployed to Preview August 3, 2023 17:36 Inactive
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from 3053545 to 2858a2e Compare November 20, 2023 17:15
@fbwoolf fbwoolf force-pushed the fix/psbt-bare-utxo-signing branch from 2858a2e to 060168b Compare November 21, 2023 01:10
@fbwoolf fbwoolf added this pull request to the merge queue Nov 21, 2023
Merged via the queue into dev with commit 954e707 Nov 21, 2023
26 checks passed
@fbwoolf fbwoolf deleted the fix/psbt-bare-utxo-signing branch November 21, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants