Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support script type 'ms' to encode an Address #55

Closed
fbwoolf opened this issue Jul 31, 2023 · 3 comments
Closed

Support script type 'ms' to encode an Address #55

fbwoolf opened this issue Jul 31, 2023 · 3 comments

Comments

@fbwoolf
Copy link

fbwoolf commented Jul 31, 2023

When calling btc.Address.encode() we are currently running into errors bc type ms throws the error, Unknown address type=ms. I attempt to resolve in our code in this PR: leather-io/extension#4060. However, I'm not sure it is the best way to handle it and would prefer it be part of your lib if possible. It would be great if all types were supported.
@fbwoolf fbwoolf mentioned this issue Jul 31, 2023
Merged
1 task
@paulmillr
Copy link
Owner

yes, ms is incorrect address type, use tr.

@fbwoolf
Copy link
Author

fbwoolf commented Jul 31, 2023

Ok, I'll let the app know that is reporting as a bug in our wallet. Being reported here: leather-io/extension#3897

@fbwoolf fbwoolf mentioned this issue Jul 31, 2023
Closed
@paulmillr
Copy link
Owner

https://learnmeabitcoin.com/technical/p2ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmillr @fbwoolf