Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected application error listing transferring stamp or SRC-20 on openstamp.io with Leather #4215

Closed
314159265359879 opened this issue Sep 12, 2023 · 8 comments · Fixed by #4168 or #4060
Assignees
Labels
area:send area:stamps bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds

Comments

@314159265359879
Copy link
Contributor

Steps to reproduce

  1. Sign in on openstamp.io with a wallet that has stamps/SRC-20 tokens
  2. Go to assets via the top right menu
  3. Transfer a token, click confirm
  4. see error (note: if the wallet does not have enough BTC to cover the fee no error will be displayed accept in the console)

Issue with a Stamp:
image

Unexpected Application Error! Unknown address type=unknown Error: Unknown address type=unknown at Object.encode (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:200337:19) at getAddressFromOutScript (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:47508:93) at chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:23824:76 at Array.map (<anonymous>) at chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:23819:42 at Object.useMemo (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144338:189) at exports.useMemo (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:150572:208) at useParsedOutputs (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:23819:27) at useParsedPsbt (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:23958:25) at PsbtSigner (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/index.js:24093:7) at Xh (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144321:137) at Wk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144444:337) at Vk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144434:389) at Uk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144434:320) at Jk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144434:180) at Ok (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144425:88) at Fk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144427:300) at jg (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144281:105) at Xk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144437:470) at Qk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144435:398) at Hk (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:144424:269) at J (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:158098:203) at MessagePort.R (chrome-extension://ldinpeekobnhjjdofggfgjlcehhmanlj/579.js:158099:128)

Issue as seen with an SRC-20 transfer
image

@314159265359879 314159265359879 added bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds labels Sep 12, 2023
@markmhendrickson
Copy link
Collaborator

markmhendrickson commented Sep 18, 2023

@fbwoolf I presume this is resolved by #4168?

@markmhendrickson markmhendrickson linked a pull request Sep 18, 2023 that will close this issue
@btcopenstamp
Copy link

btcopenstamp commented Oct 24, 2023

@markmhendrickson @fbwoolf

Hi. I am not sure what happened. The src20 transfer function worked fine on previous published Hiro version, or testing package at #4060.

However, the current situation on OpenStamp is,

  1. the transfer of SRC20 will fail just like the issue reported
  2. the transfer of Image Stamps works fine.

@314159265359879
Copy link
Contributor Author

I just received some questions on x.com it looks like they have an idea why SRC transactions can't be signed or perhaps they can assess if/how it relates to #4060 (if so). Directing them to this conversation.

image

@btcopenstamp
Copy link

@fbwoolf @markmhendrickson With SRC20 gaining popularity, many Leather users are moving to Unisat for its bare multi-sig output support. We suggest that the Leather team can help consider adding this feature.

@markmhendrickson markmhendrickson linked a pull request Nov 20, 2023 that will close this issue
1 task
@fbwoolf
Copy link
Contributor

fbwoolf commented Nov 21, 2023

@btcopenstamp can you test this again to see if it is working for you after I rebased it on our current dev branch, thanks? #4060

We are going to get it merged if it is still able to unblock you.

@btcopenstamp
Copy link

@fbwoolf Hi. It works fine both on this issue and #3897. Great to know that.

@fbwoolf
Copy link
Contributor

fbwoolf commented Nov 21, 2023

@markmhendrickson want me to merge the PR?

@markmhendrickson
Copy link
Collaborator

Yep please! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:send area:stamps bug Functionality broken bug-p2 Critical functionality broken for few users, with no clear workarounds
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants