unified patch for namespaced tags #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@scattergory what is the status of this PR? The tests are currently failing, please see this comment as it is likely the same error |
Closed
|
Closing as SVG support was just added in #271 . Apologies for not following up with you sooner @scattergory |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
svg and mathML need to be written with namespaces specified by the xmls parameter.
https://developer.mozilla.org/en-US/docs/Web/SVG/Namespaces_Crash_Course
This patch defines mathML and svg element sets for future reference, and the needingNamespace elements that have to be declared with a namespace, as well as default namespaces for SVG and mathML.
This should set up math and svg elements to work just like regular html in the karax DSL. The global variable settings can be overridden without modifying the package if the user desires.