Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scattergory patch 1 #255

Closed
wants to merge 3 commits into from

Conversation

scattergory
Copy link
Contributor

@scattergory scattergory commented Apr 23, 2023

patch vdom.nim with scheme for recognizing svg and mathML nodes;
set global variables for default svg and mathML namespaces

track elements that need a namespace when added to the DOM.
Provide a global default for Math and SVG elements
make namespace declarations user-modifiable
enums are ordinal types, so this works
shorter file size and about as readable
@geotre
Copy link
Collaborator

geotre commented Apr 23, 2023

Is this intended to be a part of #256 @scattergory? Can you unify the change to one PR?

@geotre geotre mentioned this pull request Apr 23, 2023
@scattergory
Copy link
Contributor Author

Yeah, I will make a unified PR.

@geotre
Copy link
Collaborator

geotre commented Oct 16, 2023

Closing this one too as it has been superseded by #261

@geotre geotre closed this Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants