Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update karax.nim #256

Closed
wants to merge 2 commits into from
Closed

Conversation

scattergory
Copy link
Contributor

use tests for mathML and SVG nodes to make these elements write to the DOM correctly by default

use tests for mathML and SVG nodes to make these elements write to the DOM correctly by default
@geotre geotre mentioned this pull request Apr 23, 2023
@geotre
Copy link
Collaborator

geotre commented Apr 23, 2023

Hi @scattergory thanks for the PR. There have been a few attempts previously at adding SVG/namespace support, so I would like to check back on those to understand the changes they were looking to add.

It would also be good to add tests to ensure that it works correctly.

Please ping me when it is ready to check (if you can unify #255 in as well please) and I will look over this as soon as possible

@choltreppe
Copy link
Contributor

choltreppe commented Oct 16, 2023

Hey, I'd like to push this PR over the finish line, how can I do that ?

@Araq Araq closed this Oct 16, 2023
@Araq Araq reopened this Oct 16, 2023
@Araq
Copy link
Collaborator

Araq commented Oct 16, 2023


Error: execution of an external program failed: '/__w/karax/karax/tests/tester '
.......................................
/__w/karax/karax/karax/kdom.nim(9, 10) Hint: duplicate import of 'dom'; previous import here: /__w/karax/karax/karax/kdom.nim(3, 6) [DuplicateModuleImport]
/__w/karax/karax/karax/kdom.nim(3, 6) Warning: imported and not used: 'dom' [UnusedImport]
.......................
/__w/karax/karax/karax/vstyles.nim(329, 22) Warning: implicit conversion to 'cstring' from a non-const location: aj[0]; this will become a compile time error in the future [CStringConv]
/__w/karax/karax/karax/vstyles.nim(329, 29) Warning: implicit conversion to 'cstring' from a non-const location: aj[1]; this will become a compile time error in the future [CStringConv]
.
/__w/karax/karax/karax/vdom.nim(72, 3) Hint: 'svgElements' is declared but not used [XDeclaredButNotUsed]
/__w/karax/karax/karax/vdom.nim(74, 3) Hint: 'mathElements' is declared but not used [XDeclaredButNotUsed]
.....
/__w/karax/karax/karax/karax.nim(199, 8) Error: undeclared identifier: 'svgElements'

Remember that parts of the Karax DOM also work with the native backends.

@geotre
Copy link
Collaborator

geotre commented Oct 16, 2023

I think we can close this PR as it has been superseded by #261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants