Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datastore: add update_role func #439

Merged
merged 1 commit into from
Jun 14, 2023
Merged

datastore: add update_role func #439

merged 1 commit into from
Jun 14, 2023

Conversation

TLGINO
Copy link
Contributor

@TLGINO TLGINO commented Apr 11, 2023 •
edited by jrcastro2
Loading

@TLGINO TLGINO force-pushed the feat/groups-membership-support branch from 8407791 to b3f026b Compare April 19, 2023 11:33
@TLGINO TLGINO force-pushed the feat/groups-membership-support branch from b3f026b to b2f1cf1 Compare May 9, 2023 12:33
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 2 times, most recently from d343952 to 1ff768b Compare May 11, 2023 09:23
@jrcastro2 jrcastro2 mentioned this pull request May 11, 2023
Merged
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from b993f0e to 6389a7e Compare May 12, 2023 14:55
@TLGINO TLGINO force-pushed the feat/groups-membership-support branch from 6389a7e to e87a446 Compare May 13, 2023 11:53
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from e87a446 to aae2aca Compare May 15, 2023 07:52
This was referenced May 15, 2023
Merged
Merged
Merged
@jrcastro2 jrcastro2 marked this pull request as ready for review May 16, 2023 12:52
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 2 times, most recently from a7e7896 to 49511df Compare May 19, 2023 15:38
ppanero
ppanero reviewed May 25, 2023
View reviewed changes
Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work going to the very roots of db hehe! 🚀 few questions and suggestions.

invenio_accounts/alembic/8f11b75e0995_change_accountsrole_primary_key_to_.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/models.py Show resolved Hide resolved
invenio_accounts/models.py Show resolved Hide resolved
ntarocco
ntarocco reviewed May 25, 2023
View reviewed changes
invenio_accounts/profiles/schemas.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
ppanero
ppanero reviewed May 26, 2023
View reviewed changes
invenio_accounts/api.py Outdated Show resolved Hide resolved
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 7 times, most recently from f554095 to ce5a999 Compare June 6, 2023 13:40
ntarocco
ntarocco reviewed Jun 7, 2023
View reviewed changes
invenio_accounts/api.py Outdated Show resolved Hide resolved
ntarocco
ntarocco reviewed Jun 7, 2023
View reviewed changes
invenio_accounts/api.py Outdated Show resolved Hide resolved
ntarocco
ntarocco reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, can be merged after agreed changes and alembic fix

@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from ce5a999 to e6b98fa Compare June 8, 2023 06:41
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 2 times, most recently from eccc21f to fdc28c4 Compare June 12, 2023 08:06
@kpsherva kpsherva changed the title wip: change roles db table datastore: add update_role func Jun 12, 2023
ppanero
ppanero reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@ppanero ppanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall check the copyright headers, they need 2023 updates :) Nice work! 🚀

invenio_accounts/alembic/f2522cdd5fcd_change_accountsrole_primary_key_to_.py Outdated Show resolved Hide resolved
invenio_accounts/alembic/f2522cdd5fcd_change_accountsrole_primary_key_to_.py Outdated Show resolved Hide resolved
invenio_accounts/api.py Outdated Show resolved Hide resolved
invenio_accounts/datastore.py Outdated Show resolved Hide resolved
invenio_accounts/datastore.py Outdated Show resolved Hide resolved
invenio_accounts/models.py Outdated Show resolved Hide resolved
tests/test_invenio_accounts.py Outdated Show resolved Hide resolved
tests/test_invenio_accounts.py Outdated Show resolved Hide resolved
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 2 times, most recently from dff6dce to 91c78ec Compare June 13, 2023 16:04
@TLGINO @jrcastro2
datastore: add update_role func
952e72a 
* closes inveniosoftware/invenio-app-rdm#2186
* updated cli to pass ids on create role
* models: add managed flag to group (breaking change)

Co-authored-by: jrcastro2 <[email protected]>
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 91c78ec to 952e72a Compare June 14, 2023 07:49
@kpsherva kpsherva merged commit c708c74 into inveniosoftware:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpsherva kpsherva kpsherva left review comments

@jrcastro2 jrcastro2 jrcastro2 left review comments

@ppanero ppanero ppanero left review comments

@ntarocco ntarocco ntarocco left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups membership support
5 participants
@TLGINO @ntarocco @ppanero @jrcastro2 @kpsherva