groups: updates mapping to contain description #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jrcastro2
commented
May 12, 2023
•
jrcastro2
commented
- closes Groups membership support invenio-app-rdm#2186
- NEEDS model: Update role_id column invenio-access#203
- NEEDS datastore: add update_role func invenio-accounts#439
|
Tests passing locally |
ntarocco
reviewed
May 25, 2023
jrcastro2
force-pushed
the
update-mapping
branch
2 times, most recently
from
771c584 to
b6081bb
Compare
ntarocco
approved these changes
Jun 7, 2023
kpsherva
reviewed
Jun 7, 2023
kpsherva
approved these changes
Jun 7, 2023
alejandromumo
approved these changes
Jun 7, 2023
anikachurilova
approved these changes
Jun 7, 2023
13 tasks
jrcastro2
force-pushed
the
update-mapping
branch
from
b6081bb to
72e31a6
Compare
ppanero
reviewed
Jun 12, 2023
| @@ -28,6 +28,9 @@ | |||
| } | |||
| } | |||
| }, | |||
| "description": { | |||
There was a problem hiding this comment.
topic to raise: same old question, this forces people to delete indexes and reindex. Creating a v2 would allow just querying the alias and getting them all (without having to delete/reindex, i.e. avoiding users functionality downtime). This is also possible since description is not a mandatory field.
jrcastro2
force-pushed
the
update-mapping
branch
from
72e31a6 to
aec0489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.