Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model: Update role_id column #203

Merged

Conversation

TLGINO
Copy link
Contributor

@TLGINO TLGINO commented Apr 19, 2023

@jrcastro2
Copy link
Contributor

Tests pass locally

@jrcastro2 jrcastro2 marked this pull request as ready for review May 16, 2023 12:53
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 222888d to bf6a844 Compare May 17, 2023 09:27
invenio_access/translations/messages.pot Outdated Show resolved Hide resolved
tests/test_invenio_access.py Outdated Show resolved Hide resolved
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 5 times, most recently from 40aa450 to 1bfebd5 Compare June 6, 2023 13:18
Copy link
Contributor

@ntarocco ntarocco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If/when Alembic works, this LGTM.

Copy link
Member

@alejandromumo alejandromumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however it has some changes requested from @kpsherva

@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch 3 times, most recently from 729d991 to 7351fde Compare June 9, 2023 09:27
@kpsherva kpsherva changed the title wip group membership support model: Update role_id column Jun 12, 2023
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 7351fde to 07bca7f Compare June 13, 2023 08:30
 * fix role instantiation
 * closes inveniosoftware/invenio-app-rdm#2186

Co-authored-by: jrcastro2 <[email protected]>
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 07bca7f to 5e018fa Compare June 13, 2023 16:19
@kpsherva kpsherva force-pushed the feat/groups-membership-support branch from 54f63af to 9c8f046 Compare June 14, 2023 08:26
@jrcastro2 jrcastro2 force-pushed the feat/groups-membership-support branch from 9c8f046 to c78bd0b Compare June 14, 2023 14:23
@kpsherva kpsherva merged commit 2e7df14 into inveniosoftware:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups membership support
6 participants