-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
model: Update role_id column #203
Merged
kpsherva
merged 4 commits into
inveniosoftware:master
from
TLGINO:feat/groups-membership-support
Jun 14, 2023
Merged
model: Update role_id column #203
kpsherva
merged 4 commits into
inveniosoftware:master
from
TLGINO:feat/groups-membership-support
Jun 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TLGINO
commented
Apr 19, 2023
•
edited by jrcastro2
Loading
edited by jrcastro2
- closes Groups membership support invenio-app-rdm#2186
- NEEDS datastore: add update_role func invenio-accounts#439
TLGINO
force-pushed
the
feat/groups-membership-support
branch
3 times, most recently
from
April 27, 2023 15:00
48b9023
to
7c595d5
Compare
TLGINO
force-pushed
the
feat/groups-membership-support
branch
from
May 12, 2023 13:49
7c595d5
to
006d711
Compare
This was referenced May 15, 2023
Tests pass locally |
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
from
May 17, 2023 09:27
222888d
to
bf6a844
Compare
ppanero
reviewed
May 25, 2023
invenio_access/alembic/842a62b56e60_change_fk_accountsrole_to_string.py
Outdated
Show resolved
Hide resolved
ntarocco
approved these changes
May 25, 2023
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
5 times, most recently
from
June 6, 2023 13:18
40aa450
to
1bfebd5
Compare
ntarocco
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If/when Alembic works, this LGTM.
kpsherva
reviewed
Jun 7, 2023
kpsherva
reviewed
Jun 7, 2023
alejandromumo
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however it has some changes requested from @kpsherva
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
3 times, most recently
from
June 9, 2023 09:27
729d991
to
7351fde
Compare
ppanero
reviewed
Jun 12, 2023
invenio_access/alembic/842a62b56e60_change_fk_accountsrole_to_string_downgrade.py
Outdated
Show resolved
Hide resolved
invenio_access/alembic/f9843093f686_change_fk_accountsrole_to_string_upgrade.py
Outdated
Show resolved
Hide resolved
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
from
June 13, 2023 08:30
7351fde
to
07bca7f
Compare
* fix role instantiation * closes inveniosoftware/invenio-app-rdm#2186 Co-authored-by: jrcastro2 <[email protected]>
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
from
June 13, 2023 16:19
07bca7f
to
5e018fa
Compare
kpsherva
force-pushed
the
feat/groups-membership-support
branch
from
June 14, 2023 08:26
54f63af
to
9c8f046
Compare
jrcastro2
force-pushed
the
feat/groups-membership-support
branch
from
June 14, 2023 14:23
9c8f046
to
c78bd0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.