N21-1507 copy ctl tools #4674
Closed
N21-1507 copy ctl tools #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorCapCoder
added
the
WIP
…1-1507-copy-ctl-tools # Conflicts: # apps/server/src/modules/learnroom/service/course-copy.service.ts
IgorCapCoder
removed
the
WIP
arnegns
suggested changes
Jan 4, 2024
apps/server/src/modules/board/service/board-do-copy-service/board-do-copy.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/board/service/board-do-copy-service/recursive-copy.visitor.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/board/service/board-do-copy-service/recursive-copy.visitor.ts
Outdated
Show resolved
Hide resolved
| ); | ||
|
|
||
| if (tool) { | ||
| const copiedTool: ContextExternalTool = await this.contextExternalToolService.copyContextExternalTool( |
There was a problem hiding this comment.
The copy function seems to be really specific. We could think about to move the copy function into a own service which exports a functions which does the whole loading, copying and returns the new id
| @@ -76,4 +77,39 @@ export class ContextExternalToolService { | |||
| throw new RestrictedContextMismatchLoggable(externalTool.name, contextExternalTool.contextRef.type); | |||
| } | |||
| } | |||
|
|
|||
| public async copyContextExternalTool( | |||
There was a problem hiding this comment.
I dont know how much tools we would have in a course or on a board, but we should test a copying a bunch of it
apps/server/src/modules/tool/context-external-tool/service/context-external-tool.service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/tool-version-service.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/tool/context-external-tool/service/tool-version-service.ts
Show resolved
Hide resolved
...ver/src/modules/tool/school-external-tool/service/school-external-tool-validation.service.ts
Show resolved
Hide resolved
This was referenced Jan 5, 2024
arnegns
suggested changes
Jan 8, 2024
apps/server/src/modules/learnroom/service/course-copy.service.spec.ts
Outdated
Show resolved
Hide resolved
apps/server/src/modules/learnroom/service/course-copy.service.ts
Outdated
Show resolved
Hide resolved
|
arnegns
approved these changes
Jan 8, 2024
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when copying a course the ctls are now also copied in the tolls tab as well as in the columnboard. When a custom paramter of a copied tool is protected, the value is not copied and the tool is in an incomplete status. With the addition of yet another status for tools, the validation logic is also being updated.
Links to Tickets or other pull requests
https://ticketsystem.dbildungscloud.de/browse/N21-1507
hpi-schul-cloud/nuxt-client#2979
hpi-schul-cloud/dof_app_deploy#748
Changes
Datasecurity
Deployment
New Repos, NPM pakages or vendor scripts
Approval for review
generate-client:serverwas executed in vue frontend and changes were tested and put in a PR with the same branch name.