Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N21-1507 copy ctl tools #2988

Merged
merged 36 commits into from
Jan 12, 2024
Merged

N21-1507 copy ctl tools #2988

merged 36 commits into from
Jan 12, 2024

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Jan 8, 2024 •
edited
Loading

Short Description

Enables copying of external tools when copying a course. Paramters which were marked as protected are not copied and a new status "incomplete" is added and shown after a copy is detected to have such a protected value. Incomplete tools cannot be launched

Links to Ticket and related Pull-Requests

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

image
image
image

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

IgorCapCoder and others added 30 commits January 3, 2024 16:27
@IgorCapCoder
extend locales for incomplete tool status
071be2f
@arnegns
N21-1421 WIP
dc20401
@MarvinOehlerkingCap
filter parameters with undefined values before saving a context and s…
ad24fc9 
…chool external tool and add a translation for this possible error message
@MarvinOehlerkingCap
tests
1c9b9f4
@arnegns
N21-1421 WIP
3ddf59f
@arnegns
N21-1421 WIP
0cfb64d
@arnegns
N21-1421 fixes tests
17d48cc
@arnegns
N21-1421 fixes tests 2
cd53933
@arnegns
N21-1421 increases coverage
f537985
@arnegns
N21-1421 fixes deactivation translation
db503dc
@IgorCapCoder
render ctl tool copy info when feature flag is true
36b7059
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1507-copy-ctl-tools' into N2…
90d04e8 
…1-1507-copy-ctl-tools
@arnegns
N21-1421 extracts error dialog of RoomExternalToolsSection.vue
a875eb2
@IgorCapCoder
Merge branch 'main' into N21-1507-copy-ctl-tools
62d2d39
@IgorCapCoder
generate api
6481439
@arnegns
Merge branch 'main' into N21-1421-deactivation-of-ctl-tools
bb8571f
@arnegns
N21-1421 review changes
afa5601
@arnegns
N21-1421 review changes 2
42dc43b
@arnegns
N21-1421 fixes test
2be79b9
@arnegns
N21-1421 linter
b5857a2
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1421-deactivation-of-ctl-too…
ffd3506 
…ls' into N21-1507-copy-ctl-tools

# Conflicts:
#	src/components/external-tools/configuration/ExternalToolConfigurator.unit.ts
#	src/components/external-tools/configuration/ExternalToolConfigurator.vue
#	src/locales/de.json
#	src/locales/en.json
#	src/locales/es.json
#	src/locales/uk.json
#	src/serverApi/v3/api.ts
#	src/store/external-tool/mapper/school-external-tool.mapper.ts
@arnegns
N21-1421 linter 2
44c1f41
@arnegns
N21-1421 fixes test
54b4995
@IgorCapCoder
add incomplete tool status
88e98bd
@IgorCapCoder
add launch logic to board
c0b53ce
@IgorCapCoder
Merge remote-tracking branch 'origin/N21-1421-deactivation-of-ctl-too…
6cbc66a 
…ls' into N21-1507-copy-ctl-tools

# Conflicts:
#	src/components/external-tools/configuration/ExternalToolConfigurator.vue
#	src/components/rooms/RoomExternalToolCard.vue
#	src/locales/de.json
#	src/pages/rooms/tools/RoomExternalToolsSection.vue
#	src/store/external-tool/mapper/school-external-tool.mapper.ts
@IgorCapCoder
merge N21-1421
6eb5e25
@IgorCapCoder
test and logic fix
11288ac
@IgorCapCoder
Merge branch 'main' into N21-1507-copy-ctl-tools-new
299d9b4 
# Conflicts:
#	src/components/feature-board-external-tool-element/ExternalToolElement.vue
#	src/components/feature-board-external-tool-element/ExternalToolElementAlert.unit.ts
#	src/components/feature-board-external-tool-element/ExternalToolElementAlert.vue
#	src/components/rooms/RoomExternalToolCard.vue
#	src/locales/de.json
#	src/locales/en.json
#	src/locales/es.json
#	src/locales/uk.json
#	src/pages/rooms/tools/RoomExternalToolsErrorDialog.vue
#	src/serverApi/v3/api.ts
#	src/store/external-tool/context-external-tool-configuration-status.ts
#	src/store/external-tool/mapper/common-tool.mapper.ts
#	src/store/external-tool/mapper/school-external-tool.mapper.ts
#	tests/test-utils/factory/contextExternalToolConfigurationStatusFactory.ts
#	tests/test-utils/factory/contextExternalToolConfigurationStatusResponseFactory.ts
#	tests/test-utils/factory/schoolExternalToolConfigurationFactory.ts
@IgorCapCoder
Merge branch 'main' into N21-1507-copy-ctl-tools-new
fa074d0
arnegns
arnegns suggested changes Jan 9, 2024
View reviewed changes
src/components/copy-result-modal/CopyResultModal.unit.ts Outdated Show resolved Hide resolved
src/components/data-external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/components/data-external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/components/data-external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/components/data-external-tool/ContextExternalToolConfigurationStatus.composable.unit.ts Outdated Show resolved Hide resolved
src/components/external-tools/configuration/ExternalToolConfigurator.unit.ts Show resolved Hide resolved
src/components/external-tools/configuration/ExternalToolConfigurator.vue Show resolved Hide resolved
src/components/rooms/RoomExternalToolCard.unit.ts Show resolved Hide resolved
src/pages/context-external-tool/ContextExternalToolConfigurator.page.unit.ts Show resolved Hide resolved
src/pages/rooms/tools/RoomExternalToolsErrorDialog.vue Outdated Show resolved Hide resolved
arnegns
arnegns previously approved these changes Jan 10, 2024
View reviewed changes
@IgorCapCoder
Merge branch 'main' into N21-1507-copy-ctl-tools-new
e970cb4 
# Conflicts:
#	src/store/env-config.ts
#	src/store/types/env-config.ts
This was referenced Jan 12, 2024
Merged
Merged
arnegns
arnegns previously approved these changes Jan 12, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mrikallab
mrikallab approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@mrikallab mrikallab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved because dismissed approve from Arne

@IgorCapCoder IgorCapCoder merged commit 1950c23 into main Jan 12, 2024
42 of 43 checks passed
@IgorCapCoder IgorCapCoder deleted the N21-1507-copy-ctl-tools-new branch January 12, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrikallab mrikallab mrikallab approved these changes

@arnegns arnegns arnegns left review comments

@MarvinOehlerkingCap MarvinOehlerkingCap Awaiting requested review from MarvinOehlerkingCap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgorCapCoder @arnegns @mrikallab @MarvinOehlerkingCap