Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1507 copy ctl tools #2979

Closed
wants to merge 28 commits into from
Closed

N21-1507 copy ctl tools #2979

wants to merge 28 commits into from

Conversation

IgorCapCoder
Copy link
Contributor

@IgorCapCoder IgorCapCoder commented Jan 5, 2024

Short Description

Enables copying of external tools when copying a course. Paramters which were marked as protected are not copied and a new status "incomplete" is added and shown after a copy is detected to have such a protected value. Incomplete tools cannot be launched

Links to Ticket and related Pull-Requests

https://ticketsystem.dbildungscloud.de/browse/N21-1507
hpi-schul-cloud/schulcloud-server#4674
hpi-schul-cloud/dof_app_deploy#748

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

image
image
image

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

IgorCapCoder and others added 27 commits January 3, 2024 16:27
…chool external tool and add a translation for this possible error message
…ls' into N21-1507-copy-ctl-tools

# Conflicts:
#	src/components/external-tools/configuration/ExternalToolConfigurator.unit.ts
#	src/components/external-tools/configuration/ExternalToolConfigurator.vue
#	src/locales/de.json
#	src/locales/en.json
#	src/locales/es.json
#	src/locales/uk.json
#	src/serverApi/v3/api.ts
#	src/store/external-tool/mapper/school-external-tool.mapper.ts
…ls' into N21-1507-copy-ctl-tools

# Conflicts:
#	src/components/external-tools/configuration/ExternalToolConfigurator.vue
#	src/components/rooms/RoomExternalToolCard.vue
#	src/locales/de.json
#	src/pages/rooms/tools/RoomExternalToolsSection.vue
#	src/store/external-tool/mapper/school-external-tool.mapper.ts
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
97.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants