-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BC-5405 - Metadata on k8s ressources #4517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinSchuhmacher
added
the
WIP
This feature branch is in progress, do not merge into master.
label
Nov 3, 2023
This was referenced Nov 3, 2023
This was referenced Nov 9, 2023
MartinSchuhmacher
added
waiting for review
and removed
WIP
This feature branch is in progress, do not merge into master.
labels
Nov 13, 2023
mamutmk5
requested changes
Nov 14, 2023
ansible/roles/schulcloud-server-core/templates/amqp-files-deployment.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-core/templates/amqp-files-deployment.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-core/templates/api-delete-s3-files-cronjob.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-core/templates/api-delete-s3-files-cronjob.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-core/templates/preview-generator-deployment.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-base-cronjob.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-deployment.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-deployment.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-school-cronjob.yml.j2
Outdated
Show resolved
Hide resolved
ansible/roles/schulcloud-server-tspsync/templates/api-tsp-sync-school-cronjob.yml.j2
Outdated
Show resolved
Hide resolved
mamutmk5
requested changes
Nov 16, 2023
Kudos, SonarCloud Quality Gate passed! |
mamutmk5
approved these changes
Nov 16, 2023
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need additional Metadata for the git repo, branch/tag, commit hash and the common-labels for our kubernetes Deployments and Pods.
Links to Tickets or other pull requests
BC-5405
hpi-schul-cloud/schulcloud-client#3343
hpi-schul-cloud/dof_app_deploy#689
hpi-schul-cloud/nuxt-client#2899
hpi-schul-cloud/schulcloud-calendar#150
hpi-schul-cloud/superhero-dashboard#233
hpi-schul-cloud/antivirus_check_service#43
hpi-schul-cloud/version-aggregator#12
hpi-schul-cloud/h5p-staticfiles-server#5
Changes
Approval for review
generate-client:server
was executed in vue frontend and changes were tested and put in a PR with the same branch name.