Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-5405 - Metadata on k8s ressources #2899

Merged
merged 5 commits into from
Nov 16, 2023
Merged

BC-5405 - Metadata on k8s ressources #2899

merged 5 commits into from
Nov 16, 2023

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Nov 9, 2023 •
edited
Loading

Short Description

We need additional Metadata for the git repo, branch/tag, commit hash and the common-labels for our kubernetes Deployments and Pods.

Links to Ticket and related Pull-Requests

BC-5405
hpi-schul-cloud/schulcloud-server#4517
hpi-schul-cloud/schulcloud-client#3343
hpi-schul-cloud/dof_app_deploy#689
hpi-schul-cloud/schulcloud-calendar#150
hpi-schul-cloud/superhero-dashboard#233
hpi-schul-cloud/antivirus_check_service#43
hpi-schul-cloud/version-aggregator#12
hpi-schul-cloud/h5p-staticfiles-server#5

Changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@MartinSchuhmacher MartinSchuhmacher added the WIP someone is working on that label Nov 9, 2023
@MartinSchuhmacher MartinSchuhmacher self-assigned this Nov 9, 2023
This was referenced Nov 9, 2023
Merged
Merged
Merged
This was referenced Nov 9, 2023
Merged
Merged
Merged
Merged
Merged
@MartinSchuhmacher MartinSchuhmacher added waiting for review Someone should review this ASAP and removed WIP someone is working on that labels Nov 13, 2023
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MartinSchuhmacher MartinSchuhmacher removed the waiting for review Someone should review this ASAP label Nov 16, 2023
@MartinSchuhmacher MartinSchuhmacher merged commit fd56c86 into main Nov 16, 2023
43 of 44 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5405-labels-k8s branch November 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamutmk5 mamutmk5 mamutmk5 approved these changes

Assignees

@MartinSchuhmacher MartinSchuhmacher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinSchuhmacher @mamutmk5