Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-5405 - Metadata on k8s ressources #3343

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Conversation

MartinSchuhmacher
Copy link
Contributor

@MartinSchuhmacher MartinSchuhmacher commented Oct 30, 2023

Description

We need additional Metadata for the git repo, branch/tag, commit hash and the common-labels for our kubernetes Deployments and Pods.

Links to Tickets or other pull requests

BC-5405
hpi-schul-cloud/schulcloud-server#4517
hpi-schul-cloud/dof_app_deploy#689
hpi-schul-cloud/nuxt-client#2899
hpi-schul-cloud/schulcloud-calendar#150
hpi-schul-cloud/superhero-dashboard#233
hpi-schul-cloud/antivirus_check_service#43
hpi-schul-cloud/version-aggregator#12
hpi-schul-cloud/h5p-staticfiles-server#5

Changes

Approval for review

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MartinSchuhmacher MartinSchuhmacher merged commit bc0df6f into main Nov 16, 2023
41 of 42 checks passed
@MartinSchuhmacher MartinSchuhmacher deleted the BC-5405-labels-k8s branch November 16, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants